Skip to content

RANGER-5322: PolicyRefresher can struck with no download thread if exception thrown in startRefresher #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RANGER-5322: PolicyRefresher can struck with no download thread if exception thrown in startRefresher #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a0d07a
RANGER-5322: PolicyRefresher can struck with no download thread if ex…
vyommani Sep 13, 2025
9ae1364
added test for policy refresher and fixed some small issues.
vyommani Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 30 additions & 27 deletions agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,29 @@ public void setLastActivationTimeInMillis(long lastActivationTimeInMillis) {
public void startRefresher() {
loadRoles();
loadPolicy();
initRefresher();
}

super.start();

private void initRefresher() {
LOG.debug("==> PolicyRefresher(serviceName={}).initRefresher()", serviceName);
try {
super.start();
} catch (IllegalStateException e) {
LOG.error("Failed to start PolicyRefresher thread for serviceName={}", serviceName, e);
throw e;
}
policyDownloadTimer = new Timer("policyDownloadTimer", true);

try {
policyDownloadTimer.schedule(new DownloaderTask(policyDownloadQueue), pollingIntervalMs, pollingIntervalMs);

LOG.debug("Scheduled policyDownloadRefresher to download policies every {} milliseconds", pollingIntervalMs);
} catch (IllegalStateException exception) {
LOG.error("Error scheduling policyDownloadTimer:", exception);
} catch (IllegalArgumentException | IllegalStateException | NullPointerException e) {
LOG.error("Error scheduling policyDownloadTimer:", e);
LOG.error("*** Policies will NOT be downloaded every {} milliseconds ***", pollingIntervalMs);

policyDownloadTimer.cancel();
policyDownloadTimer = null;
throw e;
}
LOG.debug("<== PolicyRefresher(serviceName={}).initRefresher()", serviceName);
}

public void stopRefresher() {
Expand Down Expand Up @@ -229,8 +237,9 @@ public void saveToCache(ServicePolicies policies) {
cacheFile = new File(realCacheDirName + File.separator + realCacheFileName);
} else {
try {
cacheDirTmp.mkdirs();

if (!cacheDirTmp.mkdirs() && !cacheDirTmp.exists()) {
LOG.error("Cannot create cache directory: {}", realCacheDirName);
}
cacheFile = new File(realCacheDirName + File.separator + realCacheFileName);
} catch (SecurityException ex) {
LOG.error("Cannot create cache directory", ex);
Expand All @@ -248,24 +257,11 @@ public void saveToCache(ServicePolicies policies) {
if (RangerPerfTracer.isPerfTraceEnabled(PERF_POLICYENGINE_INIT_LOG)) {
perf = RangerPerfTracer.getPerfTracer(PERF_POLICYENGINE_INIT_LOG, "PolicyRefresher.saveToCache(serviceName=" + serviceName + ")");
}

Writer writer = null;

try {
writer = new FileWriter(cacheFile);

try (Writer writer = new FileWriter(cacheFile)) {
JsonUtils.objectToWriter(writer, policies);
deleteOldestVersionCacheFileInCacheDirectory(cacheFile.getParentFile());
} catch (Exception excp) {
LOG.error("failed to save policies to cache file '{}'", cacheFile.getAbsolutePath(), excp);
} finally {
if (writer != null) {
try {
writer.close();
deleteOldestVersionCacheFileInCacheDirectory(cacheFile.getParentFile());
} catch (Exception excp) {
LOG.error("error while closing opened cache file '{}'", cacheFile.getAbsolutePath(), excp);
}
}
}

RangerPerfTracer.log(perf);
Expand Down Expand Up @@ -468,10 +464,17 @@ private void deleteOldestVersionCacheFileInCacheDirectory(File cacheDirectory) {
for (File f : filesInParent) {
String fileName = f.getName();
int policyVersionIdx = fileName.lastIndexOf("json_"); // Extract the part after json_
if (policyVersionIdx == -1 || policyVersionIdx + 5 >= fileName.length()) {
LOG.warn("Invalid cache file name format: {}", fileName);
continue;
}
String policyVersionStr = fileName.substring(policyVersionIdx + 5);
Long policyVersion = Long.valueOf(policyVersionStr);

policyVersions.add(policyVersion);
try {
Long policyVersion = Long.valueOf(policyVersionStr);
policyVersions.add(policyVersion);
} catch (NumberFormatException e) {
LOG.warn("Cannot parse version from file: {}", fileName, e);
}
}
} else {
LOG.info("No files matching '.+json_*' found");
Expand Down
Loading
Loading