feat(rust/sedona-testing): Add Raster Benchmarking #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontinuation
added a commit
that referenced
this pull request
Nov 14, 2025
…g arrays from struct array (#306) This optimization simply hoists per-column arrays in `RasterStructArray`, so that we don't need to extract individual arrays from the struct array each time we construct a `RasterRefImpl` value in `RasterStructArray::get`. We also marked short getters as inline so that the compiler could optimize away the construction of intermediate objects in simple metadata getter functions such as RS_Width. I've benchmarked this using the `rs_width` bench in PR #297, the performance improvement is quite significant. Baseline: ``` native-rs_width-Array(Raster(64, 64)) time: [7.3810 ms 7.3912 ms 7.4034 ms] Found 8 outliers among 100 measurements (8.00%) 5 (5.00%) high mild 3 (3.00%) high severe ``` This PR: ``` native-rs_width-Array(Raster(64, 64)) time: [474.81 µs 475.81 µs 476.75 µs] change: [-93.593% -93.576% -93.560%] (p = 0.00 < 0.05) Performance has improved. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high severe ```
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds benchmarking infrastructure for raster functions, specifically implementing a benchmark for the rs_width function. The changes introduce a new Raster variant to the BenchmarkArgSpec enum to support generating raster data for benchmarks.
Key Changes:
- Extended benchmark argument specifications to support raster data generation
- Added infrastructure to create tiled rasters with configurable dimensions for benchmarking
- Implemented a benchmark for the
rs_widthfunction using 64x64 rasters
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rust/sedona-testing/src/benchmark_util.rs |
Added Raster variant to BenchmarkArgSpec enum with support for generating tiled rasters and corresponding test coverage |
rust/sedona-raster-functions/benches/native-raster-functions.rs |
Created new benchmark file for raster functions, starting with rs_width |
rust/sedona-raster-functions/Cargo.toml |
Added benchmark configuration with criterion dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kontinuation
approved these changes
Nov 15, 2025
paleolimbot
approved these changes
Nov 15, 2025
paleolimbot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds raster bench functionality and a first benchmark for the
rs_widthIssue: #263
Sample run: