Skip to content

[SPARK-54957][PYTHON][TEST] Remove the unnecessary sleep in streaming tests #53724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaogaotiantian wants to merge 2 commits into from
+29 −24
Closed

[SPARK-54957][PYTHON][TEST] Remove the unnecessary sleep in streaming tests #53724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c6c5d
Remove the unnecessary sleep in streaming tests
gaogaotiantian Jan 8, 2026
1e94a7e
Reformat
gaogaotiantian Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 29 additions & 24 deletions python/pyspark/sql/tests/connect/streaming/test_parity_listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,14 @@ def onQueryTerminated(self, e):

q.stop()
# need to wait a while before QueryTerminatedEvent reaches client
time.sleep(5)
self.assertTrue(len(listener_good.start) > 0)
self.assertTrue(len(listener_good.progress) > 0)
self.assertTrue(len(listener_good.terminated) > 0)

@eventually(timeout=5, catch_assertions=True)
def check_listner():
self.assertTrue(len(listener_good.start) > 0)
self.assertTrue(len(listener_good.progress) > 0)
self.assertTrue(len(listener_good.terminated) > 0)

check_listner()
finally:
for listener in self.spark.streams._sqlb._listener_bus:
self.spark.streams.removeListener(listener)
Expand Down Expand Up @@ -245,26 +249,27 @@ def test_listener_events_spark_command(self):
q.stop()
self.assertFalse(q.isActive)

time.sleep(
60
) # Sleep to make sure listener_terminated_events is written successfully

start_event = pyspark.cloudpickle.loads(
self.spark.read.table("listener_start_events").collect()[0][0]
)

progress_event = pyspark.cloudpickle.loads(
self.spark.read.table("listener_progress_events").collect()[0][0]
)

terminated_event = pyspark.cloudpickle.loads(
self.spark.read.table("listener_terminated_events").collect()[0][0]
)

self.check_start_event(start_event)
self.check_progress_event(progress_event, is_stateful=True)
self.check_terminated_event(terminated_event)

events = {
"start_event": None,
"progress_event": None,
"terminated_event": None,
}

@eventually(timeout=60, catch_assertions=True)
def load_event(event_name, table_name):
table = self.spark.read.table(table_name).collect()
if len(table) == 0:
return False
events[event_name] = pyspark.cloudpickle.loads(table[0][0])
return True

load_event("start_event", "listener_start_events")
load_event("progress_event", "listener_progress_events")
load_event("terminated_event", "listener_terminated_events")

self.check_start_event(events["start_event"])
self.check_progress_event(events["progress_event"], is_stateful=True)
self.check_terminated_event(events["terminated_event"])
finally:
self.spark.streams.removeListener(test_listener)
# Remove again to verify this won't throw any error
Expand Down