Skip to content

adding ł nouns #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
EPAUL04 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

adding ł nouns #21

EPAUL04 wants to merge 10 commits into from

Conversation

@EPAUL04
Copy link
Collaborator

@EPAUL04 EPAUL04 commented May 4, 2025

No description provided.

@EPAUL04 EPAUL04 requested a review from mauraoleary May 4, 2025 17:52
mauraoleary
mauraoleary reviewed Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@mauraoleary mauraoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - @jonorthwash?

@mauraoleary mauraoleary requested a review from jonorthwash July 16, 2025 21:19
jonorthwash
jonorthwash requested changes Jul 27, 2025
View reviewed changes
Copy link
Member

@jonorthwash jonorthwash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only notice a few things:

  • Dir/Lr should be Dir/LR — the case matters
  • The "apostrophe" character should be glottal stop ʼ, not smart quote ’. It looks like this was changed even for the preexisting entries?

@jonorthwash
Copy link
Member

jonorthwash commented Jul 27, 2025

Also:

  • It looks like (some of?) the preexisting words were removed? These should always be retained, and interleaved (alphabetically) with the additions.
  • In one spot two columns run together: riverbank"bare. In such cases, we need at least one space between the columns, even if it means one column doesn't line up perfectly with the others.

@EPAUL04
Copy link
Collaborator Author

EPAUL04 commented Jul 28, 2025

I’m having difficulties fixing the smart quote issue, as the apostrophe character that appears when I type a glottal stop seems to be the smart quote, even in VSCode.

@EPAUL04
Copy link
Collaborator Author

EPAUL04 commented Oct 7, 2025

Got those smart quotes fixed!! I will re-request review on this branch

@EPAUL04 EPAUL04 requested a review from mauraoleary October 7, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonorthwash jonorthwash jonorthwash requested changes

@mauraoleary mauraoleary Awaiting requested review from mauraoleary

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@EPAUL04 @jonorthwash @mauraoleary @eternalbluepetya @anukzc