http-netty: let RetryingHttpRequesterFilter return responses on failure #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Sometimes people just want to get the last failed response when the retry loop ends. However, right now we only yield the exceptions that where created. Users can't do this smuggling themselves in a generic way via the HttpResponseException because it could lead to resource leaks. Modifications: Let users simply return the last failed response when the retry loop exits unsuccessfully.
bryce-anderson
commented
Aug 22, 2024
Comment on lines
+798
to
+801
| public Builder returnFailedResponses(final boolean returnFailedResponses) { | ||
| this.returnFailedResponses = returnFailedResponses; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
I'm certain this can have a better name and clearly it needs docs before merging. Name suggestions welcome.
There was a problem hiding this comment.
I also think this API is a bit awkward: first you must turn a response into an HttpResponseException and then it's going to be discarded. Alternatively, we could just have a different lambda to the tune of Function<Boolean, HttpResponseMetadata> shouldRetry.
bryce-anderson
commented
Aug 22, 2024
| // If we're retrying due to a wrapped response it's because the users want the actual response, | ||
| // not an exception. Therefore, we return the wrapped response and let it get unwrapped at the | ||
| // end of the retry pipeline. | ||
| subscriber.onError(t instanceof WrappedResponseException ? t : tt); |
There was a problem hiding this comment.
This pathway needs a test.
|
A risk of this PR is that it's very difficult to know for sure that the deferred response is properly drained since it gets smuggled through the error channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes people just want to get the last failed response when the retry
loop ends. However, right now we only yield the exceptions that where
created. Users can't do this smuggling themselves in a generic way via the
HttpResponseException because it could lead to resource leaks.
Modifications:
Let users simply return the last failed response when the retry loop
exits unsuccessfully.