Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-netty: let RetryingHttpRequesterFilter return responses on failure #3048

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

http-netty: let RetryingHttpRequesterFilter return responses on failure #3048

wants to merge 3 commits into from

Commits on Aug 22, 2024

  1. http-netty: let RetryingHttpRequesterFilter return responses on failure 

    Motivation:

Sometimes people just want to get the last failed response when the retry
loop ends. However, right now we only yield the exceptions that where
created. Users can't do this smuggling themselves in a generic way via the
HttpResponseException because it could lead to resource leaks.

Modifications:

Let users simply return the last failed response when the retry loop
exits unsuccessfully.
    @bryce-anderson
    bryce-anderson committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    515dd29 View commit details
    Browse the repository at this point in the history

  2. Add a test

    @bryce-anderson
    bryce-anderson committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5b7f014 View commit details
    Browse the repository at this point in the history

  3. make linters happy

    @bryce-anderson
    bryce-anderson committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b08742d View commit details
    Browse the repository at this point in the history