Pass extraPlainTextModuli to client config in validate#272
Merged
fboemer merged 8 commits intoapple:mainfrom Jan 23, 2026
Merged
Pass extraPlainTextModuli to client config in validate#272fboemer merged 8 commits intoapple:mainfrom
fboemer merged 8 commits intoapple:mainfrom
Conversation
feimaomiao
requested review from
RuiyuZhu,
fboemer and
karulont
as code owners
fboemer
reviewed
Jan 21, 2026
karulont
reviewed
Jan 21, 2026
Co-authored-by: Karl Tarbe <karulont@gmail.com>
* Use encodingEntrySize for IndexPir
Contributor
Author
|
Since there are breaking api changes from upstream, should I merge those changes and re-commit them? |
Contributor
Yes please; that should remove the breaking API changes failures. |
Contributor
|
@feimaomiao, the diff on github looks like |
Contributor
Author
|
Should be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting PR #269 into two, this PR fixes #270 ,passing extraPlainTextModuli to client configuration during the validate step, and also enforces bsgs order forces babystep >= giantstep as implicitly expected from the argument.