Skip to content

Pass extraPlainTextModuli to client config in validate #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fboemer merged 8 commits into from
Jan 23, 2026
Merged

Pass extraPlainTextModuli to client config in validate #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
018d2ef
Fix(BSGS): Removed redundant BSGS creation, enforce Bs >= Gs
feimaomiao Jan 19, 2026
dac0534
Fix: extraPlaintextModuli is passed to client config
feimaomiao Jan 19, 2026
03361ac
more precommit hooks
feimaomiao Jan 21, 2026
d2e8b74
Changed behavior in enforcing bs >= gs
feimaomiao Jan 21, 2026
5e7bc16
Update Sources/PrivateNearestNeighborSearch/MatrixMultiplication.swift
feimaomiao Jan 21, 2026
34a152e
Fix: ProcessDatabase recognizes command line argument (#271)
feimaomiao Jan 21, 2026
3b68c75
Use encodingEntrySize for IndexPir (#267)
fboemer Jan 21, 2026
d95ab57
Merge branch 'main' into bsgs-args
feimaomiao Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/PNNSProcessDatabase/ProcessDatabase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ struct ProcessDatabase: AsyncParsableCommand {
maxQueryCount: config.batchSize,
encryptionParameters: encryptionParameters,
scheme: Scheme.self),
distanceMetric: config.distanceMetric)
distanceMetric: config.distanceMetric,
extraPlaintextModuli: config.extraPlaintextModuli.map { Scheme.Scalar($0) })
let serverConfig = ServerConfig<Scheme>(
clientConfig: clientConfig,
databasePacking: config.databasePacking)
Expand Down
14 changes: 10 additions & 4 deletions Sources/PrivateNearestNeighborSearch/MatrixMultiplication.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2024-2025 Apple Inc. and the Swift Homomorphic Encryption project authors
// Copyright 2024-2026 Apple Inc. and the Swift Homomorphic Encryption project authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -32,6 +32,12 @@ public struct BabyStepGiantStep: Codable, Equatable, Hashable, Sendable {

Comment thread
feimaomiao marked this conversation as resolved.
public init(vectorDimension: Int, babyStep: Int, giantStep: Int) {
self.vectorDimension = vectorDimension

// Ensure babyStep >= giantStep for correct algorithm behavior.
// The baby-step giant-step algorithm requires this ordering.
precondition(
babyStep >= giantStep, "babyStep cannot be smaller than giantStep")

self.babyStep = babyStep
self.giantStep = giantStep
}
Expand Down Expand Up @@ -126,7 +132,9 @@ extension PlaintextMatrix {
vector ciphertextVector: CiphertextMatrix<Scheme, Scheme.CanonicalCiphertextFormat>,
using evaluationKey: EvaluationKey<Scheme>) async throws -> [Scheme.CanonicalCiphertext]
{
guard case .diagonal = packing else {
// Extract BabyStepGiantStep from the packing to ensure consistency
// between how data was packed and how it's accessed during multiplication
guard case let .diagonal(babyStepGiantStep: babyStepGiantStep) = packing else {
Comment thread
fboemer marked this conversation as resolved.
let expectedBsgs = BabyStepGiantStep(vectorDimension: dimensions.columnCount)
throw PnnsError.wrongMatrixPacking(got: packing, expected: .diagonal(babyStepGiantStep: expectedBsgs))
}
Expand Down Expand Up @@ -166,8 +174,6 @@ extension PlaintextMatrix {
// We extend this basic idea using baby-step giant-step logic from Section 6.3 of
// https://eprint.iacr.org/2018/244.pdf.

let babyStepGiantStep = BabyStepGiantStep(vectorDimension: dimensions.columnCount)

// 1) Compute v_j = theta^j(v)
var rotatedStates: [Scheme.CanonicalCiphertext] = []
rotatedStates.reserveCapacity(babyStepGiantStep.babyStep)
Expand Down