fix(makefile): platform aware default, fixes start-local #25978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25780 introduces ARGOCD_E2E_DIR making it configurable for macOS for running e2e tests.
make target
start-localuses the same procfile as e2e test and thus the same script for git-server - which defaults the value of this variable as tmp/argocd.This PR uses a platform aware default for ARGOCD_E2E_DIR in the makeefile.
with this change, git-server shows up as running with
goreman run statusas expected.Checklist: