Skip to content

fix(makefile): platform aware default, fixes start-local #25978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ranakan19 wants to merge 4 commits into
base: master
Choose a base branch
from
+3 −1
Open

fix(makefile): platform aware default, fixes start-local #25978

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6808a17
fixes start-local
ranakan19 Jan 14, 2026
526db63
delete file added unintentionally
ranakan19 Jan 14, 2026
ae0ce40
Merge branch 'master' into fixStartLocal
ranakan19 Jan 14, 2026
3e02964
Merge branch 'master' into fixStartLocal
ranakan19 Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ ARGOCD_E2E_REDIS_PORT?=6379
ARGOCD_E2E_DEX_PORT?=5556
ARGOCD_E2E_YARN_HOST?=localhost
ARGOCD_E2E_DISABLE_AUTH?=
ARGOCD_E2E_DIR?=/tmp/argo-e2e
# platform aware default, since in macOS Docker doesn't share /tmp with the host
ARGOCD_E2E_DIR?=$(shell [ "$$(uname)" = "Darwin" ] && echo "$(HOME)/argo-e2e" || echo "/tmp/argo-e2e")

ARGOCD_E2E_TEST_TIMEOUT?=90m
ARGOCD_E2E_RERUN_FAILS?=5
Expand Down Expand Up @@ -573,6 +574,7 @@ start-local: mod-vendor-local dep-ui-local cli-local
ARGOCD_GPG_ENABLED=$(ARGOCD_GPG_ENABLED) \
BIN_MODE=$(ARGOCD_BIN_MODE) \
ARGOCD_E2E_TEST=false \
ARGOCD_E2E_DIR=$(ARGOCD_E2E_DIR)
ARGOCD_APPLICATION_NAMESPACES=$(ARGOCD_APPLICATION_NAMESPACES) \
goreman -f $(ARGOCD_PROCFILE) start ${ARGOCD_START}

Expand Down
Loading