Ethdebug isoltest framework#16675
Conversation
clonker
left a comment
There was a problem hiding this comment.
Some minor comments.
Mainly it would be good to have descriptions of the test format in the header so one doesn't have to go look through the code to find out what options there are.
Beyond that quite a few things can be const qualified I think. But that's more of a nit and not an official style guide... yet. :P
9f4aacf to
bdc36c0
Compare
I applied all of the suggested changes, and went full |
clonker
left a comment
There was a problem hiding this comment.
You didn't fix the replace thing. Try defining the following test:
contract C {
function f() public pure {}
}
// ----
// .compilation:
// {
// "compiler": "<VERSION>"
// }
Simplified a bit since |
Sweet, TIL! |
6ac8d05 to
59617b9
Compare
Closes #16502.
Supports the following:
Allows matching of specific portions of the output JSON, length checks on arrays, type checks. I could remove some of the current CLI tests, but would prefer to keep them in for the time being - most of the CLI tests requests outputs other than ethdebug, and the new EthdebugTest isoltest only supports reading of ethdebug data directly. In addition, there's no checks for errors like in syntax tests, which automatically disqualified migration of all of the 'invalid' CLI tests.