-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Ethdebug isoltest framework #16675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikola-matic
wants to merge
1
commit into
develop
Choose a base branch
from
ethdebug-isoltest-migration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ethdebug isoltest framework #16675
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| /* | ||
| This file is part of solidity. | ||
|
|
||
| solidity is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by | ||
| the Free Software Foundation, either version 3 of the License, or | ||
| (at your option) any later version. | ||
|
|
||
| solidity is distributed in the hope that it will be useful, | ||
| but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| GNU General Public License for more details. | ||
|
|
||
| You should have received a copy of the GNU General Public License | ||
| along with solidity. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| // SPDX-License-Identifier: GPL-3.0 | ||
|
|
||
| #include <test/libsolidity/EthdebugTest.h> | ||
| #include <test/Common.h> | ||
|
|
||
| #include <liblangutil/DebugInfoSelection.h> | ||
|
|
||
| #include <libsolidity/interface/OptimiserSettings.h> | ||
|
|
||
| #include <boost/throw_exception.hpp> | ||
|
|
||
| #include <stdexcept> | ||
|
|
||
| using namespace solidity; | ||
| using namespace solidity::frontend; | ||
| using namespace solidity::frontend::test; | ||
| using namespace solidity::langutil; | ||
|
|
||
| EthdebugTest::EthdebugTest(std::string const& _filename): | ||
| StandardJSONTest(_filename) | ||
| { | ||
| m_optimise = m_reader.boolSetting("optimize", false); | ||
| m_optimiseYul = m_reader.boolSetting("optimize-yul", false); | ||
| m_useSSACFG = m_reader.boolSetting("compileViaSSACFG", false); | ||
|
|
||
| auto const revertStrings = revertStringsFromString(m_reader.stringSetting("revertStrings", "default")); | ||
| if (!revertStrings) | ||
| BOOST_THROW_EXCEPTION(std::runtime_error("Invalid revertStrings setting.")); | ||
| m_revertStrings = *revertStrings; | ||
| } | ||
|
|
||
| void EthdebugTest::setupCompiler(CompilerStack& _compiler) | ||
| { | ||
| AnalysisFramework::setupCompiler(_compiler); | ||
|
|
||
| _compiler.setViaIR(true); | ||
| _compiler.setExperimental(true); | ||
| if (m_useSSACFG) | ||
| _compiler.setViaSSACFG(true); | ||
|
|
||
| DebugInfoSelection selection = DebugInfoSelection::Default(); | ||
| selection.enable("ethdebug"); | ||
| _compiler.selectDebugInfo(selection); | ||
|
|
||
| _compiler.setMetadataFormat(CompilerStack::MetadataFormat::NoMetadata); | ||
| _compiler.setRevertStringBehaviour(m_revertStrings); | ||
|
|
||
| OptimiserSettings settings = m_optimise ? OptimiserSettings::standard() : OptimiserSettings::minimal(); | ||
| if (m_optimiseYul) | ||
| settings.runYulOptimiser = true; | ||
| _compiler.setOptimiserSettings(settings); | ||
| } | ||
|
|
||
| std::map<std::string, Json> EthdebugTest::collectScopes() const | ||
| { | ||
| std::map<std::string, Json> result; | ||
|
|
||
| if (compiler().state() < CompilerStack::State::CompilationSuccessful) | ||
| return result; | ||
|
|
||
| result[".resources"] = compiler().ethdebug(); | ||
| result[".compilation"] = compiler().ethdebugCompilation(); | ||
|
|
||
| static auto constexpr shortNameOf = [](std::string const& _qualified) { | ||
| size_t const colon = _qualified.rfind(':'); | ||
| return colon == std::string::npos ? _qualified : _qualified.substr(colon + 1); | ||
| }; | ||
|
|
||
| std::map<std::string, int> shortNameCount; | ||
| for (std::string const& contractName: compiler().contractNames()) | ||
| ++shortNameCount[shortNameOf(contractName)]; | ||
|
|
||
| for (std::string const& contractName: compiler().contractNames()) | ||
| { | ||
| std::string const shortName = shortNameOf(contractName); | ||
| Json const creation = compiler().ethdebug(contractName); | ||
| Json const runtime = compiler().ethdebugRuntime(contractName); | ||
| bool const emitShortAlias = shortNameCount[shortName] == 1; | ||
|
|
||
| result[contractName + ".creation"] = creation; | ||
| result[contractName + ".runtime"] = runtime; | ||
| if (emitShortAlias) | ||
| { | ||
| result[shortName + ".creation"] = creation; | ||
| result[shortName + ".runtime"] = runtime; | ||
| } | ||
| // Shortcut: "C.contract" -> the contract sub-object from creation | ||
| if (!creation.is_null() && creation.contains("contract")) | ||
| { | ||
| result[contractName + ".contract"] = creation["contract"]; | ||
| if (emitShortAlias) | ||
| result[shortName + ".contract"] = creation["contract"]; | ||
| } | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| std::pair<std::string_view, std::string_view> EthdebugTest::splitNonGlobalPath(std::string_view _path) const | ||
| { | ||
| // Qualified paths look like "source.sol:C.kind.subpath" — used to disambiguate | ||
| // when the same short contract name appears in multisource tests. | ||
| auto const colonPos = _path.find(':'); | ||
| size_t const contractStart = colonPos == std::string_view::npos ? 0 : colonPos + 1; | ||
|
|
||
| auto const firstDot = _path.find('.', contractStart); | ||
| if (firstDot == std::string_view::npos) | ||
| return {_path, ""}; | ||
|
|
||
| auto const secondDot = _path.find('.', firstDot + 1); | ||
| if (secondDot == std::string_view::npos) | ||
| return {_path, ""}; | ||
|
|
||
| solAssert(secondDot < _path.size()); | ||
| return {_path.substr(0, secondDot), _path.substr(secondDot + 1)}; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| This file is part of solidity. | ||
|
|
||
| solidity is free software: you can redistribute it and/or modify | ||
| it under the terms of the GNU General Public License as published by | ||
| the Free Software Foundation, either version 3 of the License, or | ||
| (at your option) any later version. | ||
|
|
||
| solidity is distributed in the hope that it will be useful, | ||
| but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| GNU General Public License for more details. | ||
|
|
||
| You should have received a copy of the GNU General Public License | ||
| along with solidity. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| // SPDX-License-Identifier: GPL-3.0 | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <test/libsolidity/StandardJSONTest.h> | ||
|
|
||
| #include <libsolidity/interface/DebugSettings.h> | ||
|
|
||
| namespace solidity::frontend::test | ||
| { | ||
| /// Isoltest test case for asserting against the compiler's ethdebug JSON output. | ||
| /// | ||
| /// Settings (in the `// ====` block): | ||
| /// - `EVMVersion: <constraint>` — gates whether the test runs (inherited). | ||
| /// - `optimize: <bool>` — enable optimizer (default: false). | ||
| /// - `optimize-yul: <bool>` — additionally run the Yul optimizer (default: false). | ||
| /// - `compileViaSSACFG: <bool>` — route codegen through the SSA-CFG (default: false). | ||
| /// - `revertStrings: default|strip|debug|verboseDebug` | ||
| /// — revert string behavior (default: default). | ||
| /// | ||
| /// Compilation is always performed with `viaIR=true`, `experimental=true`, ethdebug | ||
| /// debug info enabled, and metadata stripped, so the output is stable across builds. | ||
| /// | ||
| /// Scope keys exposed to expectations: | ||
| /// - Globals: `.resources`, `.compilation`. | ||
| /// - Per contract: `Contract.creation`, `Contract.runtime`, `Contract.contract`. | ||
| /// - Source-qualified per contract (when needed to disambiguate same-named | ||
| /// contracts in different sources): `source.sol:Contract.creation`, etc. | ||
| class EthdebugTest: public StandardJSONTest | ||
| { | ||
| public: | ||
| static std::unique_ptr<TestCase> create(Config const& _config) | ||
| { | ||
| return std::make_unique<EthdebugTest>(_config.filename); | ||
| } | ||
|
|
||
| EthdebugTest(std::string const& _filename); | ||
|
|
||
| protected: | ||
| void setupCompiler(CompilerStack& _compiler) override; | ||
| std::map<std::string, Json> collectScopes() const override; | ||
| std::pair<std::string_view, std::string_view> splitNonGlobalPath(std::string_view _path) const override; | ||
|
|
||
| private: | ||
| bool m_optimise = false; | ||
| bool m_optimiseYul = false; | ||
| bool m_useSSACFG = false; | ||
| RevertStrings m_revertStrings = RevertStrings::Default; | ||
| }; | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.