Skip to content

bidi backend, fix #284#396

Merged
asciimoo merged 3 commits intoasciimoo:masterfrom
drzraf:webdriver-bidi
May 7, 2026
Merged

bidi backend, fix #284#396
asciimoo merged 3 commits intoasciimoo:masterfrom
drzraf:webdriver-bidi

Conversation

@drzraf
Copy link
Copy Markdown

@drzraf drzraf commented May 5, 2026

Successfully tested with Firefox

Happened that hupe1980/gowebdriver had problems regarding leftovers sessions (closing sessions) that would lead to quickly reach browser's BiDi "max sessions". Since websocket was already pulled, it wasn't that much of an additional to internalize the session.new/browsingContext.navigate/script.evaluate/session.end flow.

fix #284

(opus 4.6)

@asciimoo
Copy link
Copy Markdown
Owner

asciimoo commented May 5, 2026

Great addition, thanks! Please fix the formatting/linter errors. NPM formatting can be fixed by running npm run format.

@drzraf drzraf force-pushed the webdriver-bidi branch from ecb7bb3 to dceb4e6 Compare May 6, 2026 20:08
@asciimoo
Copy link
Copy Markdown
Owner

asciimoo commented May 7, 2026

Seems like the formatting commits made thing worse. use golangci-lint run -v ./... to check go linting locally

@drzraf drzraf force-pushed the webdriver-bidi branch from dceb4e6 to 7a877e4 Compare May 7, 2026 12:22
Copy link
Copy Markdown
Owner

@asciimoo asciimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@asciimoo asciimoo merged commit e59cc04 into asciimoo:master May 7, 2026
7 checks passed
@drzraf
Copy link
Copy Markdown
Author

drzraf commented May 8, 2026

Just for future guidance, regarding the way you merge, I'd personally prefer merges to happen the "regular Github way" which in the UI end up referencing only the usernames instead of resulting with full name expansion.
thx

@asciimoo
Copy link
Copy Markdown
Owner

asciimoo commented May 8, 2026

Just for future guidance, regarding the way you merge.

I prefer merging this way, because in the git log tree view it is cleary shown what commits belong to a single PR. If you prefer to not display your full name, you should change it in your local git config, because otherwise either github displays it or not, it is going to end up in the git log anyway.

@drzraf
Copy link
Copy Markdown
Author

drzraf commented May 9, 2026

Sure, but aside from strict PII aspects, it's about the merging strategy respecting what users set in their GitHub preferences.

@asciimoo
Copy link
Copy Markdown
Owner

asciimoo commented May 9, 2026

it's about the merging strategy respecting what users set in their GitHub preferences.

Wouldn't it lead to an inconsistent project git log? In my experience projects use their own preferred merging strategies instead of the contributor's, no?

I've never seen anybody asking to use their preferred merging strategy before - didn't even know it is a thing. Do I miss something?

@drzraf
Copy link
Copy Markdown
Author

drzraf commented May 9, 2026

Oh, my bad. I messed-up with email addresses in my GH profile. Just forget about this. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

more flexible crawling browser choice

2 participants