bidi backend, fix #284#396
Conversation
|
Great addition, thanks! Please fix the formatting/linter errors. NPM formatting can be fixed by running |
|
Seems like the formatting commits made thing worse. use |
|
|
I prefer merging this way, because in the git log tree view it is cleary shown what commits belong to a single PR. If you prefer to not display your full name, you should change it in your local git config, because otherwise either github displays it or not, it is going to end up in the git log anyway. |
|
|
Wouldn't it lead to an inconsistent project git log? In my experience projects use their own preferred merging strategies instead of the contributor's, no? I've never seen anybody asking to use their preferred merging strategy before - didn't even know it is a thing. Do I miss something? |
|
Oh, my bad. I messed-up with email addresses in my GH profile. Just forget about this. Sorry for the noise. |
Successfully tested with Firefox
Happened that hupe1980/gowebdriver had problems regarding leftovers sessions (closing sessions) that would lead to quickly reach browser's BiDi "max sessions". Since websocket was already pulled, it wasn't that much of an additional to internalize the
session.new/browsingContext.navigate/script.evaluate/session.endflow.fix #284
(opus 4.6)