fix for entity-bound triggers error #990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a quick-fix for the issue introduced with custom-token-exchange being returned when calling the triggers API. This will continue even if the API responds with the "cannot list action bindings for an entity-bound trigger" response (400 response code)
Forgot to add this which just allows our warn to come back with the ID of the trigger that fails/warns us.
I messed up the formatting of the new log message. Fixed that here.
Contributor
|
Hi, @Ryan-Tassat This can be added on config: {
"AUTH0_EXCLUDED": ["triggers"]
} |
Author
|
Thanks @kushalshit27 - Feel free to bin this PR. The builds didn't pass 😅 - My TS is rusty and I somehow fudged the definition of triggerId |
Closed
6 tasks
kushalshit27
changed the title
kushalshit27
requested changes
Nov 27, 2024
| const triggers: string[] = _(res.data.triggers).map('id').uniq().value(); | ||
| let triggerId: string; | ||
|
|
||
| for (let i = 0; i < triggers.length; i++) { |
Contributor
There was a problem hiding this comment.
Suggested change
| for (let i = 0; i < triggers.length; i++) { | |
| for (let i = 0; i < triggers.length; i++) { | |
| const triggerId = triggers[i]; | |
| let bindings; | |
| try { | |
| const { data } = await this.client.actions.getTriggerBindings({ | |
| triggerId: triggerId, | |
| }); | |
| bindings = data?.bindings; | |
| } catch (err) { | |
| log.warn( | |
| `${err.message} (trigger: ${triggerId}). Skipping this trigger and continuing.` | |
| ); | |
| continue; | |
| } | |
| if (bindings && bindings.length > 0) { | |
| triggerBindings[triggerId] = bindings.map((binding) => ({ | |
| action_name: binding.action.name, | |
| display_name: binding.display_name, | |
| })); | |
| } | |
| } |
Hi, @Ryan-Tassat
I have added a suggestion that will only skip the a trigger that is causing the issue.
Contributor
|
I will create a new PR |
3 tasks
Contributor
|
Add a new #991 Thank you for submitting this PR! I really appreciate the time and effort you put into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Just a quick fix for the issue introduced with custom-token-exchange being returned when calling the triggers API.
This will continue even if the API responds with the "cannot list action bindings for an entity-bound trigger" response (400 response code). May be a cleaner way to do this, but it does the job for now!
All it does is adds a new check in the catch section of the try-catch that makes a call to the triggerBindings endpoint.
📚 References
🔬 Testing
Try running a full export with debug mode enabled. Without this "fix" the export will break and not complete successfully. With this fix, it'll just "warn" about the issue.
📝 Checklist