Skip to content

fix for entity-bound triggers error #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ryan-Tassat wants to merge 4 commits into from
Closed

fix for entity-bound triggers error #990

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d98729
Temp fix for entity-bound triggers error
Ryan-Tassat Nov 27, 2024
c2f7759
Define triggerId outside of loop
Ryan-Tassat Nov 27, 2024
688231e
Converted from my local js to correct ts
Ryan-Tassat Nov 27, 2024
f33764e
Fixed definition of triggerId
Ryan-Tassat Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/tools/auth0/handlers/triggers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ export default class TriggersHandler extends DefaultHandler {
try {
const res = await this.client.actions.getAllTriggers();
const triggers: string[] = _(res.data.triggers).map('id').uniq().value();
let triggerId: string;

for (let i = 0; i < triggers.length; i++) {
Copy link
Contributor

@kushalshit27 kushalshit27 Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (let i = 0; i < triggers.length; i++) {
for (let i = 0; i < triggers.length; i++) {
const triggerId = triggers[i];
let bindings;
try {
const { data } = await this.client.actions.getTriggerBindings({
triggerId: triggerId,
});
bindings = data?.bindings;
} catch (err) {
log.warn(
`${err.message} (trigger: ${triggerId}). Skipping this trigger and continuing.`
);
continue;
}
if (bindings && bindings.length > 0) {
triggerBindings[triggerId] = bindings.map((binding) => ({
action_name: binding.action.name,
display_name: binding.display_name,
}));
}
}

Hi, @Ryan-Tassat
I have added a suggestion that will only skip the a trigger that is causing the issue.

const triggerId = triggers[i];
triggerId = triggers[i];
const { data } = await this.client.actions.getTriggerBindings({
triggerId: triggerId,
});
Expand All @@ -86,6 +87,11 @@ export default class TriggersHandler extends DefaultHandler {
return {};
}

if (err.message === "cannot list action bindings for an entity-bound trigger") {
log.warn(`${err.message.charAt(0).toUpperCase()}${err.message.slice(1)} (${triggerId})`);
return {};
}

throw err;
}
}
Expand Down