Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): improve the calculation of the target lateral velocity in Frenet frame #10078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxime-clem
Copy link
Contributor

Description

This PR makes the lane change paths generated in Frenet frame smoother.
The previous calculation did not work as expected, and the new calculation simply assumes a constant acceleration over the whole lane change duration, starting from a 0 lateral velocity and targeting some positive lateral velocity calculated as the lateral distance to travel divided by the lane change duration.

Before After
lc1 lc_fixed1
lc2 lc_fixed2
lc3 lc_fixed3
lc4 lc_fixed4
lc5 lc_fixed5
lc_fixed_max

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 6, 2025
@maxime-clem maxime-clem added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (421d9ec) to head (892b526).

Files with missing lines Patch % Lines
...ehavior_path_lane_change_module/src/utils/path.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10078      +/-   ##
==========================================
- Coverage   28.30%   28.30%   -0.01%     
==========================================
  Files        1485     1486       +1     
  Lines      111091   111118      +27     
  Branches    43152    43154       +2     
==========================================
+ Hits        31445    31448       +3     
- Misses      76626    76651      +25     
+ Partials     3020     3019       -1     
Flag Coverage Δ *Carryforward flag
differential 21.04% <0.00%> (?)
total 28.30% <ø> (+<0.01%) ⬆️ Carriedforward from 421d9ec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant