Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(multi_object_tracker): internal message driven process #10203

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Feb 28, 2025

Description

refactor tracker process by internally defined structure messages

  • integrated classes
    • DynamicObject : object related structure. shorten overall codes
      • remove size variables from tracker and integrate to DynamicObject member
    • InputChannel : integrate channel related configuration
    • AssociatorConfig : association configuration is collected as a struct
  • simplify argument passses
    • channel size channel_size is removed
    • position of the ego vehicle self_transform passed to all of the trackers is removed
    • tracker variable anchor_point for vehicle tracking is integrated to DynamicObject class
  • Shape related process is moved to input manager
    • input channel processes getNearestCornerOrSurface for all inputs. it is moved from the vehicle tracker

Related links

Parent Issue:

  • Link

How was this PR tested?

TIER IV INTERNAL
123/123 passed

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Feb 28, 2025
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 28, 2025
Copy link

github-actions bot commented Feb 28, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 28, 2025
@technolojin technolojin force-pushed the feat/multi-object-tracker/internal-message-driven-process branch from 67c2570 to f8caa05 Compare February 28, 2025 07:01
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 405 lines in your changes missing coverage. Please review.

Project coverage is 26.25%. Comparing base (df2ceec) to head (ec8c982).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...multi_object_tracker/src/debugger/debug_object.cpp 0.00% 45 Missing ⚠️
...ject_tracker/lib/tracker/model/vehicle_tracker.cpp 0.00% 40 Missing ⚠️
...i_object_tracker/src/multi_object_tracker_node.cpp 0.00% 40 Missing ⚠️
...t_tracker/lib/tracker/model/pedestrian_tracker.cpp 0.00% 39 Missing ⚠️
...ject_tracker/lib/tracker/model/bicycle_tracker.cpp 0.00% 37 Missing ⚠️
...lti_object_tracker/lib/association/association.cpp 0.00% 32 Missing ⚠️
...e_multi_object_tracker/lib/object_model/shapes.cpp 0.00% 28 Missing ⚠️
...e_multi_object_tracker/src/processor/processor.cpp 0.00% 28 Missing ⚠️
...lti_object_tracker/src/processor/input_manager.cpp 0.00% 23 Missing ⚠️
...tracker/lib/tracker/model/pass_through_tracker.cpp 0.00% 20 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10203      +/-   ##
==========================================
+ Coverage   26.22%   26.25%   +0.03%     
==========================================
  Files        1378     1378              
  Lines      107415   107286     -129     
  Branches    41391    41377      -14     
==========================================
  Hits        28168    28168              
+ Misses      76241    76112     -129     
  Partials     3006     3006              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.35% <ø> (+0.13%) ⬆️ Carriedforward from df2ceec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@technolojin technolojin force-pushed the feat/multi-object-tracker/internal-message-driven-process branch 2 times, most recently from 7eca62e to 8ba5612 Compare March 10, 2025 05:58
technolojin and others added 6 commits March 10, 2025 16:00
…n handling

feat(multi_object_tracker): introduce InputChannel struct for input channel configuration

refactor(multi_object_tracker): improve marker handling and initialization in TrackerObjectDebugger

feat(multi_object_tracker): enhance InputChannel with trust flags for object properties

refactor(multi_object_tracker): remove unused channel_size parameter from tracker constructors

feat(multi_object_tracker): update InputChannel flags to trust object extension and classification

fix(multi_object_tracker): replace channel.index with channel_index for consistency

feat(multi_object_tracker): update TrackerObjectDebugger and TrackerProcessor to accept channels_config parameter

refactor(multi_object_tracker): remove redundant existence probability initialization from tracker constructors

feat(multi_object_tracker): integrate data association into TrackerProcessor and add associate method

feat(multi_object_tracker): enhance updateWithMeasurement to include channel_info for improved classification handling

refactor(multi_object_tracker): replace object_id with uuid in DynamicObject and related classes

fix(multi_object_tracker): update UUID handling in Tracker to use uuid_msg for consistency

refactor(multi_object_tracker): simplify pose and covariance handling in tracker classes

refactor(multi_object_tracker): replace pose_with_covariance with separate pose and covariance attributes in DynamicObject

refactor: remove z state from tracker. it will uses object state

refactor(multi_object_tracker): streamline object handling in trackers and remove unnecessary shape processing

refactor(multi_object_tracker): remove z position handling from trackers and update object kinematics structure

refactor(multi_object_tracker): remove BoundingBox structure from trackers and implement object extension limits

refactor(multi_object_tracker): remove unnecessary blank lines in tracker getTrackedObject methods

refactor(multi_object_tracker): simplify input channel configuration by removing trust flags and consolidating parameters

Signed-off-by: Taekjin LEE <[email protected]>
…_msgs::msg::Point for anchor vectors

Signed-off-by: Taekjin LEE <[email protected]>
…tion signature and update related logic

Signed-off-by: Taekjin LEE <[email protected]>

refactor(multi_object_tracker): remove self_transform parameter from measure and update methods

refactor(multi_object_tracker): update calcAnchorPointOffset function signature and streamline object handling

refactor(multi_object_tracker): set shape type to BOUNDING_BOX for object trackers
@technolojin technolojin force-pushed the feat/multi-object-tracker/internal-message-driven-process branch from 8ba5612 to ec8c982 Compare March 10, 2025 08:27
@technolojin technolojin marked this pull request as ready for review March 11, 2025 00:09
@technolojin technolojin requested a review from ogrex March 11, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant