Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light_classifier): update diagnostics when harsh backlight is detected #10218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Mar 3, 2025

Description

This PR introduces diagnostics publisher in order to warn if any classifications are overwritten by UNKNOWN when harsh backlight are detected.

image

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

Change type Topic Type Topic Name Message Type Description
Added Pub /diagnostics diagnostic_msgs/msg/DiagnosticArray Topic description

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ktro2828 ktro2828 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 26.55%. Comparing base (1b37970) to head (ccc5e67).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...t_classifier/src/traffic_light_classifier_node.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10218      +/-   ##
==========================================
+ Coverage   26.26%   26.55%   +0.29%     
==========================================
  Files        1378     1385       +7     
  Lines      107444   106982     -462     
  Branches    41426    41053     -373     
==========================================
+ Hits        28221    28410     +189     
+ Misses      76403    75742     -661     
- Partials     2820     2830      +10     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 26.56% <ø> (+0.29%) ⬆️ Carriedforward from 11d6b0c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktro2828 ktro2828 marked this pull request as ready for review March 11, 2025 06:37
@ktro2828 ktro2828 assigned ktro2828 and MasatoSaeki and unassigned ktro2828 Mar 11, 2025
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked no degradation using dlrv2 on my local pc.
And I added some data in PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants