refactor(autoware_velocity_run_out_module): prefix package with autoware_ and move code to the autoware namespace #7154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
added
the
tag:run-build-and-test-differential
github-actions
bot
added
type:documentation
esteve
force-pushed
the
prefix-behavior_velocity_run_out_module
branch
3 times, most recently
from
6b6fe98
to
82e4636
Compare
esteve
requested review from
kosuke55,
mkuri,
shmpwk,
takayuki5168,
TomohitoAndo,
tkimura4,
kyoichi-sugahara,
soblin,
maxime-clem,
satoshi-ota,
taikitanaka3,
rej55,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
soblin
approved these changes
Jun 4, 2024
esteve
force-pushed
the
prefix-behavior_velocity_run_out_module
branch
from
514c0d6
to
81e1d40
Compare
kosuke55
approved these changes
Jun 5, 2024
esteve
force-pushed
the
prefix-behavior_velocity_run_out_module
branch
2 times, most recently
from
d7ed2b2
to
0aacd09
Compare
…are_ and move code to the autoware namespace Signed-off-by: Esteve Fernandez <[email protected]>
danielsanchezaran
force-pushed
the
prefix-behavior_velocity_run_out_module
branch
from
5a49d25
to
a9dd147
Compare
danielsanchezaran
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4,
YamatoAndo and
meliketanrikulu
as code owners
|
@esteve Sorry I fixed the merge conflicts but accidentally added other things, I wil;l fix this and get this PR to merge |
danielsanchezaran
force-pushed
the
prefix-behavior_velocity_run_out_module
branch
from
abfef08
to
12af9c2
Compare
kosuke55
approved these changes
Jun 6, 2024
|
@danielsanchezaran thanks, no problem. What additionals changes did you add? |
|
@danielsanchezaran in general, it's frowned upon to force-push other people's branches, so please don't do it in the future. Thanks. |
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…are_ and move code to the autoware namespace (#7154) * refactor(autoware_velocity_run_out_module): prefix package with autoware_ and move code to the autoware namespace Signed-off-by: Esteve Fernandez <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Esteve Fernandez <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.
Part of:
autowarefoundation/autoware#4569
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.