refactor(control_validator)!: prefix package and namespace with autoware #7304

danielsanchezaran · 2024-06-06T06:15:13Z

Description

Part of:

Prefix packages with autoware_ prefix and keep code in autoware namespace autoware#4569

Add autoware prefix

Tests performed

PSim, checked that node and topic work as usual

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kyoichi-sugahara · 2024-06-06T09:39:37Z

control/autoware_control_validator/image/control_validator.drawio.svg

autoware_autoware_autoware_....?

kyoichi-sugahara · 2024-06-06T10:37:04Z

@danielsanchezaran
~~here also should be changed?~~
how did you perform test?

kyoichi-sugahara · 2024-06-06T10:45:01Z

control/autoware_control_validator/README.md


-![control_validator](./image/control_validator.drawio.svg)
+![autoware_control_validator](./image/autoware_control_validator.drawio.svg)


Suggested change

![autoware_control_validator](./image/autoware_control_validator.drawio.svg)

![autoware_control_validator](./image/control_validator.drawio.svg)

kyoichi-sugahara · 2024-06-06T10:45:23Z

control/autoware_control_validator/README.md

-| `/diagnostics`               | diagnostic_msgs/DiagnosticStatus         | diagnostics to report errors                                              |
+| Name                         | Type                                              | Description                                                               |
+| ---------------------------- | ------------------------------------------------- | ------------------------------------------------------------------------- |
+| `~/output/validation_status` | autoware_control_validator/ControlValidatorStatus | validator status to inform the reason why the trajectory is valid/invalid |


Suggested change

| `~/output/validation_status` | autoware_control_validator/ControlValidatorStatus | validator status to inform the reason why the trajectory is valid/invalid |

| `~/output/validation_status` | control_validator/ControlValidatorStatus | validator status to inform the reason why the trajectory is valid/invalid |

danielsanchezaran · 2024-06-06T13:01:38Z

@danielsanchezaran
~~here also should be changed?~~
how did you perform test?

Psim and checked the output from the validator topic and that the node exists

ito-san

Could anyone please fix the CODEOWNERS errors?

ito-san

LGTM

danielsanchezaran · 2024-06-10T06:33:05Z

Could anyone please fix the CODEOWNERS errors?

Yhank you for your message, we will fix the codeowners in a different PR after the Autoware prefix adding PRs are merged.

Signed-off-by: Daniel Sanchez <[email protected]>

rej55 · 2024-06-10T10:30:31Z

control/autoware_control_validator/src/control_validator.cpp

@@ -61,7 +61,7 @@ void ControlValidator::setupParameters()
  }

  try {
-    vehicle_info_ = autoware::vehicle_info_utils::VehicleInfoUtils(*this).getVehicleInfo();
+    vehicle_info_ = autoware::vehicle_info_utils::VehicleInfoUtil(*this).getVehicleInfo();


@danielsanchezaran
It seems that it has a mistake to change

Fixed in
#7417

…are (#7304) * rename folders Signed-off-by: Daniel Sanchez <[email protected]> * rename add prefix Signed-off-by: Daniel Sanchez <[email protected]> * change param path Signed-off-by: Daniel Sanchez <[email protected]> * fix pluggin problem Signed-off-by: Daniel Sanchez <[email protected]> * fix extra prefixes Signed-off-by: Daniel Sanchez <[email protected]> * change back launchers Signed-off-by: Daniel Sanchez <[email protected]> * add namespace to address conflict Signed-off-by: Daniel Sanchez <[email protected]> * delete stubborn file Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>

danielsanchezaran marked this pull request as ready for review June 6, 2024 06:16

danielsanchezaran requested review from ito-san, TakaHoribe, takayuki5168, kyoichi-sugahara, mkuri and soblin as code owners June 6, 2024 06:16

danielsanchezaran added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 6, 2024

danielsanchezaran assigned danielsanchezaran and kyoichi-sugahara Jun 6, 2024

kyoichi-sugahara reviewed Jun 6, 2024

View reviewed changes

control/autoware_control_validator/image/control_validator.drawio.svg Outdated

Copy link

Contributor

kyoichi-sugahara Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoware_autoware_autoware_....?

kyoichi-sugahara reviewed Jun 6, 2024

View reviewed changes

xmfcx mentioned this pull request Jun 6, 2024

Prefix packages with autoware_ prefix and keep code in autoware namespace autowarefoundation/autoware#4569

Open

danielsanchezaran changed the title ~~feat(control_validator): add autoware prefix to control validator~~ feat(control_validator): prefix package and namespace with autoware_ Jun 6, 2024

danielsanchezaran force-pushed the add-autoware-prefix-to-control-validator branch from a6e86d3 to aaa803c Compare June 7, 2024 04:23

kyoichi-sugahara changed the title ~~feat(control_validator): prefix package and namespace with autoware_~~ refactor(control_validator)!: prefix package and namespace with autoware Jun 7, 2024

kyoichi-sugahara approved these changes Jun 7, 2024

View reviewed changes

ito-san reviewed Jun 10, 2024

View reviewed changes

takayuki5168 approved these changes Jun 10, 2024

View reviewed changes

ito-san self-requested a review June 10, 2024 05:30

ito-san approved these changes Jun 10, 2024

View reviewed changes

danielsanchezaran enabled auto-merge (squash) June 10, 2024 07:43

danielsanchezaran added 7 commits June 10, 2024 17:06

rename folders

441f8b4

Signed-off-by: Daniel Sanchez <[email protected]>

rename add prefix

887a5dd

Signed-off-by: Daniel Sanchez <[email protected]>

change param path

0d69360

Signed-off-by: Daniel Sanchez <[email protected]>

fix pluggin problem

2f9e3be

Signed-off-by: Daniel Sanchez <[email protected]>

fix extra prefixes

ab438c3

Signed-off-by: Daniel Sanchez <[email protected]>

change back launchers

b9f3951

Signed-off-by: Daniel Sanchez <[email protected]>

add namespace to address conflict

8c97463

Signed-off-by: Daniel Sanchez <[email protected]>

danielsanchezaran force-pushed the add-autoware-prefix-to-control-validator branch from dfd3a0a to 8c97463 Compare June 10, 2024 08:10

danielsanchezaran disabled auto-merge June 10, 2024 08:11

delete stubborn file

2e1609e

Signed-off-by: Daniel Sanchez <[email protected]>

danielsanchezaran enabled auto-merge (squash) June 10, 2024 08:15

danielsanchezaran added 2 commits June 10, 2024 17:59

fix include

5516086

Signed-off-by: Daniel Sanchez <[email protected]>

solve name change again

820f05e

Signed-off-by: Daniel Sanchez <[email protected]>

danielsanchezaran merged commit 7a55d57 into autowarefoundation:main Jun 10, 2024
24 checks passed

danielsanchezaran deleted the add-autoware-prefix-to-control-validator branch June 10, 2024 09:45

rej55 reviewed Jun 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(control_validator)!: prefix package and namespace with autoware #7304

refactor(control_validator)!: prefix package and namespace with autoware #7304

danielsanchezaran commented Jun 6, 2024 •

edited

Loading

kyoichi-sugahara Jun 6, 2024

kyoichi-sugahara commented Jun 6, 2024 •

edited

Loading

kyoichi-sugahara Jun 6, 2024

kyoichi-sugahara Jun 6, 2024

danielsanchezaran commented Jun 6, 2024

ito-san left a comment

ito-san left a comment

danielsanchezaran commented Jun 10, 2024

rej55 Jun 10, 2024

rej55 Jun 10, 2024


		![control_validator](./image/control_validator.drawio.svg)
		![autoware_control_validator](./image/autoware_control_validator.drawio.svg)

	![autoware_control_validator](./image/autoware_control_validator.drawio.svg)
	![autoware_control_validator](./image/control_validator.drawio.svg)

	\| `~/output/validation_status` \| autoware_control_validator/ControlValidatorStatus \| validator status to inform the reason why the trajectory is valid/invalid \|
	\| `~/output/validation_status` \| control_validator/ControlValidatorStatus \| validator status to inform the reason why the trajectory is valid/invalid \|

refactor(control_validator)!: prefix package and namespace with autoware #7304

refactor(control_validator)!: prefix package and namespace with autoware #7304

Conversation

danielsanchezaran commented Jun 6, 2024 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

kyoichi-sugahara Jun 6, 2024

Choose a reason for hiding this comment

kyoichi-sugahara commented Jun 6, 2024 • edited Loading

kyoichi-sugahara Jun 6, 2024

Choose a reason for hiding this comment

kyoichi-sugahara Jun 6, 2024

Choose a reason for hiding this comment

danielsanchezaran commented Jun 6, 2024

ito-san left a comment

Choose a reason for hiding this comment

ito-san left a comment

Choose a reason for hiding this comment

danielsanchezaran commented Jun 10, 2024

rej55 Jun 10, 2024

Choose a reason for hiding this comment

rej55 Jun 10, 2024

Choose a reason for hiding this comment

danielsanchezaran commented Jun 6, 2024 •

edited

Loading

kyoichi-sugahara commented Jun 6, 2024 •

edited

Loading