-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_departure_checker)!: prefix package and namespace with autoware #7325
Merged
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:prefix-lane_departure_checker
Jun 7, 2024
Merged
refactor(lane_departure_checker)!: prefix package and namespace with autoware #7325
kyoichi-sugahara
merged 5 commits into
autowarefoundation:main
from
kyoichi-sugahara:prefix-lane_departure_checker
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoichi-sugahara
requested review from
danielsanchezaran,
kosuke55,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4,
rej55,
go-sakayori,
maxime-clem,
TakaHoribe,
takayuki5168,
zulfaqar-azmi-t4 and
mkuri
as code owners
June 6, 2024 11:37
maxime-clem
reviewed
Jun 6, 2024
kyoichi-sugahara
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jun 6, 2024
...ne_departure_checker/include/autoware_lane_departure_checker/lane_departure_checker_node.hpp
Outdated
Show resolved
Hide resolved
kyoichi-sugahara
force-pushed
the
prefix-lane_departure_checker
branch
from
June 6, 2024 12:26
f2ea2da
to
19a4af0
Compare
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
labels
Jun 6, 2024
xmfcx
changed the title
chore(lane_departure_checker): add prefix autoware_ to
refactor(lane_departure_checker)!: prefix package and namespace with autoware_
Jun 6, 2024
lane_departure_checker
package
kyoichi-sugahara
changed the title
refactor(lane_departure_checker)!: prefix package and namespace with autoware_
refactor(lane_departure_checker)!: prefix package and namespace with autoware
Jun 6, 2024
zulfaqar-azmi-t4
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kyoichi-sugahara
force-pushed
the
prefix-lane_departure_checker
branch
2 times, most recently
from
June 7, 2024 04:34
9934054
to
d4165e5
Compare
4 tasks
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
kyoichi-sugahara
force-pushed
the
prefix-lane_departure_checker
branch
from
June 7, 2024 06:23
d873404
to
d4f1f49
Compare
satoshi-ota
approved these changes
Jun 7, 2024
mkuri
approved these changes
Jun 7, 2024
takayuki5168
approved these changes
Jun 7, 2024
kyoichi-sugahara
merged commit Jun 7, 2024
f03323f
into
autowarefoundation:main
21 of 23 checks passed
This was referenced Jun 10, 2024
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…autoware (#7325) * add prefix autoware_ to lane_departure_checker package Signed-off-by: kyoichi-sugahara <[email protected]> --------- Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rename package to autoware_lane_departure_checker from lane_departure_checker.
Part of:
Tests performed
run psim and confirmed lane departure check is working appropriately in start_planner
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.