Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(localization_util)!: prefix package and namespace with autoware #8922

Conversation

a-maumau
Copy link
Contributor

Description

This PR will add the autoware_ prefix to localization_util package.

Related links

Parent Issue:

How was this PR tested?

Checked with running the autoware sample-map.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Sep 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Sep 19, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well.

Also, I checked

  • Directory Name

    • Add autoware_ as a prefix to the directory name.
  • packages.xml

    • Add autoware_ to the name element.
  • CMakeLists.txt

    • Change the project name to autoware_***.
  • Header Files (.hpp)

    • Add autoware:: to namespace.
    • Add autoware folder as necessary and update include statements accordingly.
  • Verification Points

    • Search find-pkg-share in autoware
    • Check README file (especially json schema)
    • Pay attention to complex cases like sensor_launch as seen in gnss_poser

LGTM!

@SakodaShintaro SakodaShintaro enabled auto-merge (squash) September 19, 2024 07:59
@SakodaShintaro SakodaShintaro merged commit f8dc16f into autowarefoundation:main Sep 19, 2024
40 of 42 checks passed
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 31.03448% with 20 lines in your changes missing coverage. Please review.

Project coverage is 28.16%. Comparing base (2791c53) to head (ecad289).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...are_ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 46.66% 8 Missing ⚠️
...ar_marker_localizer/src/lidar_marker_localizer.cpp 0.00% 5 Missing ⚠️
...autoware_landmark_manager/src/landmark_manager.cpp 0.00% 3 Missing ⚠️
...are_pose_initializer/src/pose_initializer_core.cpp 0.00% 2 Missing ⚠️
...tag_based_localizer/src/ar_tag_based_localizer.cpp 50.00% 1 Missing ⚠️
...n_error_monitor/src/localization_error_monitor.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8922      +/-   ##
==========================================
+ Coverage   27.97%   28.16%   +0.18%     
==========================================
  Files        1319     1331      +12     
  Lines       98732    99099     +367     
  Branches    39804    39909     +105     
==========================================
+ Hits        27621    27909     +288     
- Misses      71078    71157      +79     
  Partials       33       33              
Flag Coverage Δ *Carryforward flag
differential 25.95% <31.03%> (?)
total 27.97% <ø> (-0.01%) ⬇️ Carriedforward from 2791c53

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants