-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(localization_util)!: prefix package and namespace with autoware #8922
refactor(localization_util)!: prefix package and namespace with autoware #8922
Conversation
Signed-off-by: a-maumau <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator
works well.
Also, I checked
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
.
- Change the
-
Header Files (.hpp)
- Add
autoware::
tonamespace
. - Add
autoware
folder as necessary and update include statements accordingly.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
LGTM!
f8dc16f
into
autowarefoundation:main
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8922 +/- ##
==========================================
+ Coverage 27.97% 28.16% +0.18%
==========================================
Files 1319 1331 +12
Lines 98732 99099 +367
Branches 39804 39909 +105
==========================================
+ Hits 27621 27909 +288
- Misses 71078 71157 +79
Partials 33 33
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This PR will add the autoware_ prefix to
localization_util
package.Related links
Parent Issue:
How was this PR tested?
Checked with running the autoware sample-map.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.