Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_ekf_localizer): publish processing time detail #9245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Nov 6, 2024

Description

There are several tools for visualizing processing_time in autoware_tools.

However, autoware_ekf_localizer currently does not publish the required topic. To use the above tools, a node needs to publish a topic with the type autoware::universe_utils::ProcessingTimeDetail (link1, link2).

Therefore, this pull request adds a processing_time publisher to autoware_ekf_localizer

How was this PR tested?

(1) processing_time_visualizer

ros2 run autoware_debug_tools processing_time_visualizer

Screenshot from 2024-11-06 15-58-45

Screenshot from 2024-11-06 15-59-16

(2) system_performance_plotter

ros2 bag record -o /path/to/result_rosbag --use-sim-time -e '.*processing_time.*'

and

ros2 run autoware_debug_tools processing_time_plotter /path/to/result_rosbag -c localization -s --skip_plt_show

The result directory is generated at current directory.

localization_processing_time-24-11-06-16-02-03

Notes for reviewers

None.

Interface changes

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added Pub ~/debug/processing_time_ms tier4_debug_msgs::msg::ProcessingTimeTree The processing time

Under default settings, this is /localization/pose_twist_fusion_filter/ekf_localizer/debug/processing_time_ms.

Effects on system behavior

None.

Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 6, 2024
@SakodaShintaro SakodaShintaro self-assigned this Nov 6, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.19%. Comparing base (d77ac21) to head (7c9da94).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ation/autoware_ekf_localizer/src/ekf_localizer.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9245      +/-   ##
==========================================
- Coverage   29.20%   29.19%   -0.01%     
==========================================
  Files        1335     1335              
  Lines      102906   102896      -10     
  Branches    39925    39915      -10     
==========================================
- Hits        30051    30044       -7     
  Misses      69770    69770              
+ Partials     3085     3082       -3     
Flag Coverage Δ *Carryforward flag
differential 27.58% <83.33%> (?)
total 29.19% <ø> (-0.01%) ⬇️ Carriedforward from 5f2126f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro
Copy link
Contributor Author

I misunderstood. processing_time_plotter.py is currently only for Float64Stamped and does not seem to support ProcessingTimeDetail. I will consider what to do next.

https://github.com/autowarefoundation/autoware_tools/blob/3c33924534c5b3a2c7b997ff04b232adc87853a8/common/autoware_debug_tools/autoware_debug_tools/system_performance_plotter/processing_time_plotter.py#L32-L33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant