Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compare_map_segmentation): timer period mismatched with parameter #9259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

badai-nguyen
Copy link
Contributor

Description

  • To fix the mismatch between the timer period and the intended parameter value.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@badai-nguyen badai-nguyen added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.17%. Comparing base (6c4de54) to head (cf97a33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9259      +/-   ##
==========================================
- Coverage   29.17%   29.17%   -0.01%     
==========================================
  Files        1336     1336              
  Lines      103032   103044      +12     
  Branches    39962    39964       +2     
==========================================
  Hits        30060    30060              
- Misses      69939    69951      +12     
  Partials     3033     3033              
Flag Coverage Δ *Carryforward flag
differential 7.25% <ø> (?)
total 29.17% <ø> (+<0.01%) ⬆️ Carriedforward from 6c4de54

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen marked this pull request as ready for review November 7, 2024 12:00
@badai-nguyen
Copy link
Contributor Author

@takam5f2 Could you review this PR as issue reporter, and @yukkysaito, as code owner?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takam5f2
Copy link
Contributor

@badai-nguyen
Sorry for my late reply. Now I'd like to check this PR today. Please wait for a while.

Copy link
Contributor

@takam5f2 takam5f2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Thanks! I found that it worked intentionally on my desktop and checked it with CARET.

I don't like create_timer interface that receives only variable of period whose unit is nanoseconds, but it is not blocking for the PR.

Screenshot 2024-11-12 at 21-40-36 Untitled ipynb - JupyterLab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants