Attempt multi scope no deps #802
Conversation
| @@ -102,7 +106,7 @@ void write() throws IOException { | |||
| private void writeRequiredModules() { | |||
|
|
|||
| ProcessingContext.modules(); | |||
| Set<String> requiredModules = new TreeSet<>(); | |||
| List<String> requiredModules = new ArrayList<>(); | |||
There was a problem hiding this comment.
Probably not needed - I ran into an issue where it was complaining about missing required scopes, so was trying a few things until I made the change to have the scope auto-provide itself
| import io.avaje.inject.InjectModule; | ||
| import jakarta.inject.Scope; | ||
|
|
||
| @Scope | ||
| @InjectModule(requires = {ModAModule.class, ModBModule.class}) | ||
| @InjectModule(requires = {ModAScope.class, ModBScope.class}) |
There was a problem hiding this comment.
These being modules or scopes is a hard one by the looks:
- If they are modules, then we don't need to add to the autoProvides (although it works without this PR without doing that 🤔 )
- If they are scopes, you can easily find the scopes they rely on
But then, either way, it (currently) falls down when you attempt to extract the module dependencies to build the method... So maybe having them as modules is better? Although then you may be trying to read something from the annotation that doesn't yet exist and I've ran into that before as a problem in another project...
There was a problem hiding this comment.
so modules in the annotation doesn't fly because the module classes don't exist by the time the processor tries to read them
SentryMan
force-pushed
the
attempt_multi_scope_no_deps
branch
from
830baa9 to
3fd05dc
Compare
|
I've pulled your changes into #800 |
An attempt at building off of @SentryMan's
allRequiredModulesmethod...It doesn't work for modules that have dependencies though, and I couldn't easily see a way to automatically bail if that was the case. It does work for the
blackbox-multi-scopethough...Sorry, wasn't sure where to put this attempt, and boiling down the changes I made to write in a ticket would probably be difficult.