Use Rust 1.81+ #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use bindgen 0.70, since 0.71 adds ‘unsafe extern’ to generated C bindings, which isn’t supported until 1.82.
‘unsafe extern’ wasn’t supported until Rust 1.82.
Including 1.81, our minimum, plus stable and nightly.
Pinned to v1.12.0’s commit hash, 9d7e65c320fdb52dcd45ffaa68deb6c02c8754d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
We had
rust-version = 1.70with notes about why this was the minimum from a compiler point-of-view, but neglected to take into account the crates dependency tree, which requires 1.81 or later.The Solution
Use
rust-version = 1.81Changes
0.70for bindgen, the latest version to support1.81.rust-versionto1.81.1.81compatible (don't useunsafe extern).1.81,stable, andnightly.Planned version bump
PATCHNotes
There are no logic changes here, just improved and more clear tooling.