Skip to content

Use Rust 1.81+ #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
## The Problem

[ What are you trying to solve? Why are you trying to solve it? ]

## The Solution

[ How are you fixing the problem? High-level explanation. ]

### Changes

[ A more detailed explanation of the solution to guide reviewers. Point out tricky or magic areas. ]

### Planned version bump

- Which: [ `MAJOR`, `MINOR`, `PATCH` ]
- Why: [ non-breaking bug fix, doc change, test coverage, formatting, debugging, profiling, security fix, internal change, experimental change, non-breaking new functionality, breaking change, etc ]

### Links

* [ Any important other PRs, Issues, PRs, etc? ]

## Notes

[ @mentions for anyone who should be alerted to this PR ]

[ **Please assign reviewers if you want someone specific to review this** ]

[ **Please do not forget to add labels specific to this PR** ]
39 changes: 16 additions & 23 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,40 +4,33 @@ on:
push:
pull_request:
workflow_dispatch:
# used when called manually.
workflow_call:
# used when called by _another_ workflow (not when called on this repo!)

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
rust-toolchain:
- "1.81" # minimum for this crate
- "stable"
- "nightly"
steps:
- uses: actions/checkout@v4 # not pinning to commit since this is a GitHub action, which we trust
- id: cache-cargo
name: Cache Cargo toolchain
uses: actions/cache@v4 # not pinning to commit since this is a GitHub action, which we trust
- uses: actions/checkout@v4 # not pinning to commit hash since this is a GitHub action, which we trust
- uses: actions-rust-lang/setup-rust-toolchain@9d7e65c320fdb52dcd45ffaa68deb6c02c8754d9 # v1.12.0
with:
path: |
~/.cargo/bin/
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-release
- if: ${{ steps.cache-cargo.outputs.cache-hit != 'true' }}
name: Install Rust toolchain
uses: actions-rs/toolchain@v1 # not pinning to commit since this is an archived GitHub action, which we trust
with:
profile: minimal
toolchain: stable
override: true
toolchain: ${{ matrix.rust-toolchain }}
components: rustfmt, clippy
- name: Check
run: cargo check
- name: Architecture check
run: cargo run arch-check
- name: Architecture check (Optimized)
run: cargo run --features=optimize_crc32_auto arch-check
- name: Format
- if: ${{ matrix.rust-toolchain != 'nightly' }}
name: Format
run: cargo fmt -- --check
- name: Clippy
- if: ${{ matrix.rust-toolchain != 'nightly' }}
name: Clippy
run: cargo clippy
- name: Test
run: cargo test
Expand Down
105 changes: 56 additions & 49 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading