Skip to content

Disable the SMUS generative AI extension in SMAI and disable jupyter-… #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andychoquette
Copy link
Contributor

…ai extension in SMUS

Description

SMUS will support a single generative AI chat experience provided by sagemaker_gen_ai_jupyterlab_extension. to accomplish this in SMUS spaces, jupyter-ai will be disabled.

In SMAI, jupyter-ai will be the single generative AI chat experience, so the sagemaker_gen_ai_jupyterlab_extension will be disabled in SMAI spaces.

Testing Done

Manually disabled the extensions using the commands included in start-jupyter-server and start-sagemaker-ui-jupyter-server and confirmed only one chat experience exists after running command.

Description

See above

Type of Change

  • Image update - Bug fix
  • [ X ] Image update - New feature
  • Image update - Breaking change
  • SMD image build tool update
  • Documentation update

Release Information

Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.

  • Yes (Critical bug fix or security update)
  • [ X ] No (New feature or non-critical change)
  • N/A (Not an image update)

If yes, please explain why:

How Has This Been Tested?

Manually disabled the extensions using the commands included in start-jupyter-server and start-sagemaker-ui-jupyter-server and confirmed only one chat experience exists after running command.

Checklist:

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Test Screenshots (if applicable):

Related Issues

[Link any related issues here]

Additional Notes

[Any additional information that might be helpful for reviewers]

…ai extension in SMUS

**Description**

SMUS will support a single generative AI chat experience provided by sagemaker_gen_ai_jupyterlab_extension. to accomplish this in SMUS spaces, jupyter-ai will be disabled.

In SMAI, jupyter-ai will be the single generative AI chat experience, so the sagemaker_gen_ai_jupyterlab_extension will be disabled in SMAI spaces.

**Testing Done**

Manually disabled the extensions using the commands included in start-jupyter-server and start-sagemaker-ui-jupyter-server and confirmed only one chat experience exists after running command.
@andychoquette andychoquette requested a review from a team as a code owner July 8, 2025 21:51
@@ -10,6 +10,9 @@ if [ -n "$SAGEMAKER_RECOVERY_MODE" ]; then
else
# Activate conda environment 'base' which is the default for Cosmos
micromamba activate base

# Disable jupyter-ai in favor of sagemaker_gen_ai_jupyterlab_extension
jupyter labextension disable @jupyter-ai/core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to disable the q chat extension amazon_sagemaker_jupyter_ai_q_developer?
Also the change to include the new extension should be done in the same releaase - lets hold off on merging this until we are ready to add the new extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants