Skip to content

Disable the SMUS generative AI extension in SMAI and disable jupyter-… #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template/v2/dirs/usr/local/bin/start-jupyter-server
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if [ -n "$SAGEMAKER_RECOVERY_MODE" ]; then
else
# Activate conda environment 'base'
micromamba activate base
jupyter labextension disable @amzn/sagemaker-data-explorer-jl-plugin sagemaker-data-explorer:plugin amzn/sagemaker-ui-theme-jlplugin @amzn/sagemaker-ui-doc-manager-jl-plugin @amzn/sagemaker-connection-magics-jlextension
jupyter labextension disable @amzn/sagemaker-data-explorer-jl-plugin sagemaker-data-explorer:plugin amzn/sagemaker-ui-theme-jlplugin @amzn/sagemaker-ui-doc-manager-jl-plugin @amzn/sagemaker-connection-magics-jlextension sagemaker_gen_ai_jupyterlab_extension
fi

# Start Jupyter server in rtc mode for shared spaces
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ if [ -n "$SAGEMAKER_RECOVERY_MODE" ]; then
else
# Activate conda environment 'base' which is the default for Cosmos
micromamba activate base

# Disable jupyter-ai in favor of sagemaker_gen_ai_jupyterlab_extension
jupyter labextension disable @jupyter-ai/core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to disable the q chat extension amazon_sagemaker_jupyter_ai_q_developer?
Also the change to include the new extension should be done in the same releaase - lets hold off on merging this until we are ready to add the new extension.

fi

sudo cp -r /etc/sagemaker-ui/kernels/. /opt/conda/share/jupyter/kernels/
Expand Down
2 changes: 1 addition & 1 deletion template/v3/dirs/usr/local/bin/start-jupyter-server
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if [ -n "$SAGEMAKER_RECOVERY_MODE" ]; then
else
# Activate conda environment 'base'
micromamba activate base
jupyter labextension disable @amzn/sagemaker-data-explorer-jl-plugin sagemaker-data-explorer:plugin amzn/sagemaker-ui-theme-jlplugin @amzn/sagemaker-ui-doc-manager-jl-plugin @amzn/sagemaker-connection-magics-jlextension
jupyter labextension disable @amzn/sagemaker-data-explorer-jl-plugin sagemaker-data-explorer:plugin amzn/sagemaker-ui-theme-jlplugin @amzn/sagemaker-ui-doc-manager-jl-plugin @amzn/sagemaker-connection-magics-jlextension sagemaker_gen_ai_jupyterlab_extension
fi

# Start Jupyter server in rtc mode for shared spaces
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ if [ -n "$SAGEMAKER_RECOVERY_MODE" ]; then
else
# Activate conda environment 'base' which is the default for Cosmos
micromamba activate base

# Disable jupyter-ai in favor of sagemaker_gen_ai_jupyterlab_extension
jupyter labextension disable @jupyter-ai/core
fi

sudo cp -r /etc/sagemaker-ui/kernels/. /opt/conda/share/jupyter/kernels/
Expand Down