Fix incorrect folder coverage calculation #6614
Conversation
bhoomiiee
requested review from
a team,
deshmukhmayur,
riginoommen and
yashoswalyo
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Unexpected ChangesetsThe following changeset(s) reference packages that have not been changed in this PR:
Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets. Changed Packages
|
|
Thanks for the contribution! |
bhoomiiee
force-pushed
the
fix/code-coverage-folder-percentage
branch
2 times, most recently
from
4bbaa99 to
cc5c3e2
Compare
Added notice about limited support for new frontend and hybrid migration setups in the Feedback plugin documentation. Signed-off-by: bhoomiiee <[email protected]> Signed-off-by: Bhoomi <[email protected]>
Signed-off-by: Bhoomi<[email protected]> Signed-off-by: Bhoomi <[email protected]>
Signed-off-by: Bhoomi<[email protected]> Signed-off-by: Bhoomi <[email protected]>
Signed-off-by: Bhoomi <[email protected]>
bhoomiiee
force-pushed
the
fix/code-coverage-folder-percentage
branch
from
cc5c3e2 to
ff52c18
Compare
.changeset/config.json
Outdated
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
Removed the accidentally added .changeset/config.json file and pushed the fix. Please let me know if anything else is needed.
| '@backstage-community/plugins': patch | ||
| --- | ||
|
|
||
| docs(feedback): add new frontend / hybrid migration notice |
There was a problem hiding this comment.
run yarn changeset from the code-coverage workspace instead of the root
There was a problem hiding this comment.
I regenerated the changeset from the plugin-code-coverage workspace (not root) and pushed the update. Please let me know if anything else is needed.
|
|
||
| ### Plugin Setup | ||
|
|
||
| ## New Frontend / Hybrid Migration Notice |
There was a problem hiding this comment.
these changes aren't expected right?
There was a problem hiding this comment.
these changes aren't expected right?
You are right that README change was not intended for this PR. I have reverted it and pushed the update. Thanks for pointing it out.
Signed-off-by: Bhoomi <[email protected]>
Signed-off-by: Bhoomi <[email protected]>
Signed-off-by: Bhoomi <[email protected]>
bhoomiiee
force-pushed
the
fix/code-coverage-folder-percentage
branch
from
b6e890b to
9294cd8
Compare
3 participants
What this PR does
Fixes folder-level coverage calculation in the FileExplorer by computing coverage
from aggregated tracked and missing lines instead of averaging child percentages.
Why
Previously, folder coverage was calculated as a simple average of child coverage
values, which produced incorrect results. This change aligns the folder coverage
with the values shown in the History section.
Formula used
coverage = ((tracked - missing) / tracked) * 100