Skip to content

Fix incorrect folder coverage calculation #6614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhoomiiee wants to merge 7 commits into
base: main
Choose a base branch
from
+40 −15
Open

Fix incorrect folder coverage calculation #6614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c390b9f
docs(feedback): add new frontend migration notice
bhoomiiee Dec 21, 2025
56aef27
chore(changeset): add patch changeset for feedback docs
bhoomiiee Dec 21, 2025
4fe6cd0
docs(feedback): clarify legacy vs new frontend setup steps
bhoomiiee Dec 21, 2025
ff52c18
Fix folder coverage calculation using aggregated tracked/missing lines
bhoomiiee Dec 23, 2025
eb886f4
chore(code-coverage):format FileExplorer with Prettier
bhoomiiee Dec 24, 2025
b3bdc2c
chore: remove accidently added changeset config
bhoomiiee Dec 27, 2025
9294cd8
Add changeset for code coverage folder coverage fix
bhoomiiee Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-code-coverage-folder-percentage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@backstage-community/plugin-code-coverage': patch
---

Fix folder coverage calculation to use aggregated tracked and missing lines instead of averaging child coverage percentages.
5 changes: 5 additions & 0 deletions .changeset/pretty-items-try.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@backstage-community/plugins': patch
---

docs(feedback): add new frontend / hybrid migration notice
Copy link
Member

@vinzscam vinzscam Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run yarn changeset from the code-coverage workspace instead of the root

Copy link
Contributor Author

@bhoomiiee bhoomiiee Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I regenerated the changeset from the plugin-code-coverage workspace (not root) and pushed the update. Please let me know if anything else is needed.

33 changes: 18 additions & 15 deletions workspaces/code-coverage/plugins/code-coverage/src/components/FileExplorer/FileExplorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,27 +93,30 @@ const removeVisitedPathGroup = (

export const buildFileStructure = (row: CoverageTableRow) => {
const dataGroupedByPath: FileStructureObject = groupByPath(row.files);

row.files = Object.keys(dataGroupedByPath).map(pathGroup => {
const aggregatedTracked = dataGroupedByPath[pathGroup].reduce(
(acc: number, cur: CoverageTableRow) => acc + cur.tracked,
0,
);

const aggregatedMissing = dataGroupedByPath[pathGroup].reduce(
(acc: number, cur: CoverageTableRow) => acc + cur.missing,
0,
);

return buildFileStructure({
path: pathGroup,
files: dataGroupedByPath.hasOwnProperty('files')
? removeVisitedPathGroup(dataGroupedByPath.files, pathGroup)
: removeVisitedPathGroup(dataGroupedByPath[pathGroup], pathGroup),
files: removeVisitedPathGroup(dataGroupedByPath[pathGroup], pathGroup),
coverage:
dataGroupedByPath[pathGroup].reduce(
(acc: number, cur: CoverageTableRow) => acc + cur.coverage,
0,
) / dataGroupedByPath[pathGroup].length,
missing: dataGroupedByPath[pathGroup].reduce(
(acc: number, cur: CoverageTableRow) => acc + cur.missing,
0,
),
tracked: dataGroupedByPath[pathGroup].reduce(
(acc: number, cur: CoverageTableRow) => acc + cur.tracked,
0,
),
aggregatedTracked > 0
? ((aggregatedTracked - aggregatedMissing) / aggregatedTracked) * 100
: 0,
missing: aggregatedMissing,
tracked: aggregatedTracked,
});
});

return row;
};

Expand Down
12 changes: 12 additions & 0 deletions workspaces/feedback/plugins/feedback/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,18 @@ It is dedicated to simplifying the process of gathering and managing user feedba

### Plugin Setup

## New Frontend / Hybrid Migration Notice
Copy link
Member

@vinzscam vinzscam Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes aren't expected right?

Copy link
Contributor Author

@bhoomiiee bhoomiiee Dec 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes aren't expected right?

You are right that README change was not intended for this PR. I have reverted it and pushed the update. Thanks for pointing it out.


The Feedback plugin currently has limited support for the new
Backstage frontend and hybrid migration setups.

The following steps are **legacy frontend only**:

- Adding routes in `App.tsx` using `FlatRoutes`
- Registering components directly in `AppRouter`

## The backend configuration and catalog annotations remain the same for both legacy and new frontend setups.

1. Install the plugin in your environment

```bash
Expand Down
Loading