Stripe whitespace from webhook URL's #2378
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy-pasted webhook URLs (which is probably the most common way users add them) often include accidental trailing whitespace, which
type="url"accepts butURI.parserejects. Because the controller usescreate!/update!this results in a silent failure where the form re-renders with cleared input and no error.This PR normalizes webhook URLs by stripping leading/trailing whitespace before validation. Since trailing whitespace is not meaningful user input and is the only case that slips past browser validation, normalizing at the model boundary avoids unnecessary UX and code complexity compared to rendering form errors.
This shows the before/after (leaving trailing whitespace re-renders cleared form with no explanation and then with this fix in place).
normalization-fix.mp4