Skip to content

Strip whitespace from webhook URL's #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robzolkos wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

Strip whitespace from webhook URL's #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64059e2
Add test for webhook URL with trailing whitespace
robzolkos Jan 16, 2026
d8b6ea8
Strip whitespace from webhook URLs
robzolkos Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/webhook.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class Webhook < ApplicationRecord
after_create :create_delinquency_tracker!

normalizes :subscribed_actions, with: ->(value) { Array.wrap(value).map(&:to_s).uniq & PERMITTED_ACTIONS }
normalizes :url, with: -> { it.strip }

validates :name, presence: true
validate :validate_url
Expand Down
4 changes: 4 additions & 0 deletions test/models/webhook_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ class WebhookTest < ActiveSupport::TestCase

webhook = Webhook.new name: "HTTPS", board: boards(:writebook), url: "https://example.com/webhook"
assert webhook.valid?

webhook = Webhook.new name: "TRAILING SPACE", board: boards(:writebook), url: "https://example.com/webhook "
assert webhook.valid?
assert_equal "https://example.com/webhook", webhook.url
end

test "deactivate" do
Expand Down