Copy over runfiles library from Bazel#239
Conversation
|
@hvadehra @meteorcloudy I just realized that we could also move this over and delete it from bazel_tools. What do you think? We could fix bazelbuild/bazel#24150 here. |
|
The move sounds fine to me. I'll let @hvadehra do the review. |
.../runfiles/src/main/java/com/google/devtools/build/runfiles/AutoBazelRepositoryProcessor.java
Outdated
Show resolved
Hide resolved
I included the fix in bazelbuild/bazel#24161 |
b2b36ed to
debe9bd
Compare
|
No longer stacked |
3cc5085 to
2cbac3a
Compare
|
@hvadehra This is ready for review now, CI is green. |
|
@hvadehra Friendly ping |
ff52380 to
77d33a8
Compare
|
@Wyverald |
The runfiles library can be maintained independently of Bazel releases and `bazel_tools` can refer to it via an alias. Also set flags to build and test with a hermetic JDK 8 to ensure compatibility with that version.
I'm aware of this (decided not to try to fix it since it's too much work). Is it blocking you? |
|
If you are aware of this it's fine, it just means that rules_java can't use it yet. |
|
@fmeum This is causing a few issues on import, could you please change the newly added |
|
@hvadehra Done |
|
@hvadehra Could you cut a new release so that this can be integrated into bazelbuild/bazel#24219? |
The runfiles library can be maintained independently of Bazel releases and
bazel_toolscan refer to it via an alias.Also set flags to build and test with a hermetic JDK 8 to ensure compatibility with that version.