Skip to content

Move Bash and Python runfiles libraries out of Bazel#24219

Closed
fmeum wants to merge 5 commits intobazelbuild:masterfrom
fmeum:drop-shell-runfiles-library
Closed

Move Bash and Python runfiles libraries out of Bazel#24219
fmeum wants to merge 5 commits intobazelbuild:masterfrom
fmeum:drop-shell-runfiles-library

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 6, 2024 •
edited
Loading

The Bash and Python runfiles libraries in @bazel_tools are replaced with aliases to @rules_<lang>//<lang>/runfiles.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

@fmeum fmeum changed the title Move Bash runfiles library out of Bazel Move runfiles libraries out of Bazel Nov 6, 2024
@fmeum fmeum force-pushed the drop-shell-runfiles-library branch 3 times, most recently from 973d791 to 46db68e Compare November 6, 2024 11:16
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 6, 2024

FYI @comius, let me know if you want to merge this as is (Bash + Python).

This was referenced Nov 15, 2024
Closed
Closed
@comius
Copy link
Contributor

comius commented Nov 19, 2024

FYI @comius, let me know if you want to merge this as is (Bash + Python).

It looks ok to me.

@fmeum fmeum marked this pull request as ready for review November 19, 2024 16:05
@fmeum fmeum changed the title Move runfiles libraries out of Bazel Move Bash and Python runfiles libraries out of Bazel Nov 19, 2024
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 19, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 19, 2024

@comius I updated the description, feel free to merge this. I will open a new PR for Java and C++.

@fmeum fmeum requested a review from comius November 19, 2024 18:12
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 19, 2024

@bazel-io fork 8.0.0

@bazel-io bazel-io mentioned this pull request Nov 19, 2024
Closed
@iancha1992 iancha1992 added the team-Rules-Python Native rules for Python label Nov 19, 2024
@comius comius added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 20, 2024
@iancha1992
Copy link
Member

iancha1992 commented Nov 20, 2024

@fmeum Can you please resolve the conflicts? Thanks!

@fmeum fmeum force-pushed the drop-shell-runfiles-library branch from 46db68e to 006cf31 Compare November 20, 2024 22:25
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 20, 2024

@iancha1992 Done!

@iancha1992
Copy link
Member

iancha1992 commented Nov 20, 2024

@fmeum Looks like one of the tests is failing

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 21, 2024

@iancha1992 Looks like CI has trouble connecting to github.com.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 21, 2024

@iancha1992 I sent #24425 to fix this, I guess that the failing tests just aren't supposed to hit anything other than the mirror.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 21, 2024

@Wyverald Both https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/01934dca-8eef-4338-b6e7-d88f65fd1281/src/test/shell/bazel/workspace_test/shard_1_of_5/test_attempts/attempt_1.log and https://storage.googleapis.com/bazel-untrusted-buildkite-artifacts/01934dca-8eef-4338-b6e7-d88f65fd1281/src/test/shell/bazel/workspace_test/shard_5_of_5/test_attempts/attempt_1.log have server crashes triggered by download failures.

@fmeum fmeum force-pushed the drop-shell-runfiles-library branch 3 times, most recently from 30f2982 to c7d4613 Compare November 22, 2024 15:14
@meteorcloudy
Copy link
Member

meteorcloudy commented Dec 3, 2024

I see, we were having some trouble importing this change, I guess internal we still have to keep a copy of runfiles.bash at the old location.

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 3, 2024

I see, we were having some trouble importing this change, I guess internal we still have to keep a copy of runfiles.bash at the old location.

I suspect that's because your copybara rewrite for the runfiles path doesn't apply to the BUILD file line I linked. That should be the only place that needs changing.

@fmeum fmeum force-pushed the drop-shell-runfiles-library branch from bd91bd9 to 1d4bd9c Compare January 30, 2025 18:35
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 30, 2025

@meteorcloudy I resolved the merge conflict. Is the import blocked? I can try to help with issues you encounter.

@iancha1992
Copy link
Member

iancha1992 commented Jan 30, 2025

@meteorcloudy I resolved the merge conflict. Is the import blocked? I can try to help with issues you encounter.

We'll try and import this now. Thank you so much @fmeum

@iancha1992
Copy link
Member

iancha1992 commented Jan 30, 2025

@fmeum could you please take a look at the presubmit errors?

@fmeum fmeum force-pushed the drop-shell-runfiles-library branch from 1d4bd9c to a2955eb Compare January 31, 2025 08:40
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 31, 2025

@iancha1992 Fixed

@comius
Copy link
Contributor

comius commented Feb 17, 2025

I had to split Shell and Python, because of internal setup. I will send out 2 commits for this PR.

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 17, 2025
copybara-service bot pushed a commit that referenced this pull request Feb 17, 2025
@comius @copybara-github
Move Python runfiles libraries out of Bazel
72baf24 
The Python libraries in @bazel_tools are replaced with aliases to @rules_python//python/runfiles.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

Closes #24219.

PiperOrigin-RevId: 727910063
Change-Id: I8323378b8688ed1a95b0ff014d00fbee42267536
@fmeum fmeum deleted the drop-shell-runfiles-library branch February 18, 2025 21:50
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Feb 20, 2025
@fmeum @iancha1992
Move Bash runfiles libraries out of Bazel
382f050 
The Bash libraries in `@bazel_tools` are replaced with aliases to `@rules_shell//shell/runfiles`.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

Closes bazelbuild#24219.

PiperOrigin-RevId: 727843225
Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c
@iancha1992 iancha1992 mentioned this pull request Feb 20, 2025
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented May 7, 2025

@bazel-io fork 8.3.0

@bazel-io bazel-io mentioned this pull request May 7, 2025
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 15, 2025

@bazel-io fork 8.3.0

@bazel-io bazel-io mentioned this pull request Jun 15, 2025
Closed
fmeum added a commit to fmeum/bazel that referenced this pull request Jun 15, 2025
@fmeum
[8.3.0] Move Bash runfiles libraries out of Bazel
4240c66 
The Bash libraries in `@bazel_tools` are replaced with aliases to `@rules_shell//shell/runfiles`.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

Closes bazelbuild#24219.

PiperOrigin-RevId: 727843225
Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c
(cherry picked from commit b8b91e4)
@fmeum fmeum mentioned this pull request Jun 15, 2025
Merged
fmeum added a commit to fmeum/bazel that referenced this pull request Jun 15, 2025
@fmeum
[8.3.0] Move Bash runfiles libraries out of Bazel
e62b28e 
The Bash libraries in `@bazel_tools` are replaced with aliases to `@rules_shell//shell/runfiles`.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

Closes bazelbuild#24219.

PiperOrigin-RevId: 727843225
Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c
(cherry picked from commit b8b91e4)
github-merge-queue bot pushed a commit that referenced this pull request Jun 16, 2025
@fmeum
[8.3.0] Move Bash runfiles libraries out of Bazel (#26304)
92ab2bc 
The Bash libraries in `@bazel_tools` are replaced with aliases to
`@rules_shell//shell/runfiles`.

This requires skipping load visibility checks for resolved WORKSPACE
files, which are going away anyway.

Closes #24219.

PiperOrigin-RevId: 727843225
Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c 
(cherry picked from commit b8b91e4)

Fixes #26303
@iancha1992
Copy link
Member

iancha1992 commented Jun 16, 2025 •
edited
Loading

The changes in this PR have been included in Bazel 8.3.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=8.3.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comius comius comius approved these changes

Assignees

No one assigned

Labels

team-Rules-Python Native rules for Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fmeum @comius @iancha1992 @meteorcloudy @alexeagle @bazel-io