Fix unbatchable meshes. #18761
Merged
Fix unbatchable meshes. #18761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
added
C-Bug
|
I'm not confident enough to review the code, but can confirm this fixes the stress in #18536 breaking when meshes are frustum culled (Win10/Vulkan/Nvidia). |
|
I've pushed this fix to a branch on top of the 0.16.0-rc.3 if anyone want to test it before merging: https://github.com/mockersf/bevy/tree/16.0-rc.3-with-18761 |
mockersf
approved these changes
Apr 8, 2025
|
Tested against my issue in #18736 and happy to report this is fixing it even with the gltf using shape-keys! Thank you so much! |
JMS55
approved these changes
Apr 8, 2025
pcwalton
approved these changes
Apr 8, 2025
| // but let's go ahead and do the sensible thing anyhow: demote | ||
| // the compressed `NoDynamicOffsets` field to the full | ||
| // `DynamicOffsets` array. | ||
| warn!( |
There was a problem hiding this comment.
I'd just make this an error!
tychedelia
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Apr 9, 2025
# Objective Fixes #18550. Because bin state for unbatchable meshes wasn't being cleared each frame, the buffer indices for unbatchable meshes would demote from sparse to dense storage and aggressively leak memory, with all kinds of weird consequences downstream, namely supplying invalid instance ranges for render. ## Solution Clear out the unbatchable mesh bin state when we start a new frame.
jf908
pushed a commit
to jf908/bevy
that referenced
this pull request
May 12, 2025
# Objective Fixes bevyengine#18550. Because bin state for unbatchable meshes wasn't being cleared each frame, the buffer indices for unbatchable meshes would demote from sparse to dense storage and aggressively leak memory, with all kinds of weird consequences downstream, namely supplying invalid instance ranges for render. ## Solution Clear out the unbatchable mesh bin state when we start a new frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #18550.
Because bin state for unbatchable meshes wasn't being cleared each frame, the buffer indices for unbatchable meshes would demote from sparse to dense storage and aggressively leak memory, with all kinds of weird consequences downstream, namely supplying invalid instance ranges for render.
Solution
Clear out the unbatchable mesh bin state when we start a new frame.