Skip to content

Make load gltf public #20225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiangheng90
Copy link
Contributor

@jiangheng90 jiangheng90 commented Jul 21, 2025

In some case, there are many gltf like format which I need to parse to make custom loader, so I make load_gltf to a static method public on GltfLoader

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-glTF Related to the glTF 3D scene/model format labels Jul 21, 2025
Copy link
Contributor

@ChristopherBiscardi ChristopherBiscardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me. I'm not aware of a way to do multiple-asset-single-binary-blob without manually handling it like this, and glTF handling tends to be complicated comparatively so benefits from being usable like this.

for more context: the older .b3dm file format embeds the glTF (newer format uses glTF extensions). So this would mean an AssetLoader implementation for .b3dm that reads the header and table, then ends up holding a blob of glTF that it also needs to process. So having this be pub makes sense, but also might encourage more people to write custom glTF processors since we don't really have an established way to add glTF extension processing afaik.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-glTF Related to the glTF 3D scene/model format C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants