Extract text colors per glyph #20245
Open
+74
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Colors are extracted per text section, transforms per glyph.
This makes it awkward to set colors for individual glyphs as they have to be batched separately.
Solution
color: LinearRgba
andtranslation: Vec2
fields toExtractedGlyph
.transform
fields fromExtractedGlyph
andExtractedUiItem
toExtractedUiNode
.rect
field fromExtractedUiNode
toExtractedUiItem
.ExtractedUiNode
s are smaller by 16 bytes, from 208 to 192 bytes in size.ExtractedGlyph
s are smaller by 8 bytes, from 48 to 40 bytes in size.Testing
Output from the UI examples should be unchanged, main ones to check are
testbed_ui
,testbed_full_ui
,text_debug
,text_wrap_debug
andui_transform
.Not a performance motivated change but this should show a marginal improvement over main, YMMV: