Fixing crash when minimizing a window with custom viewport for 0.16. (#16704) #20781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
alice-i-cecile
added
A-Rendering
alice-i-cecile
added
the
S-Nominated-To-Close
|
The 0.17 release candidate is imminent: I don't think we should or are going to release another 0.16 point release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix a crash on minimizing a window when the window contains Camera with a custom Viewport (#16704). This is the same as #18916, but targeting the 0.16.2 branch so that developers won't have to wait until the 0.17 release for the fix.
Solution
Remove ExtractedCamera when the corresponding camera in main world has zero target size. It indicates that the window is minimized.
Testing
Tested in Windows 10, the original PR was tested on Windows 11. Previously the split_screen example crashes when the window is minimized; and with this change, it would not crash. Other behaviors remain unchanged.