Skip to content

Implement VisitAssetDependencies for Arrays #20805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
+21 −0
Merged

Implement VisitAssetDependencies for Arrays #20805

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1f3534
Impl VisitAssetDependencies for Arrays
Glory2Antares Aug 30, 2025
89b94bc
Add tests
Glory2Antares Aug 31, 2025
d6a2641
Merge branch 'bevyengine:main' into impl-visit-asset-dependencies-for…
Glory2Antares Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions crates/bevy_asset/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,22 @@ impl VisitAssetDependencies for Option<UntypedHandle> {
}
}

impl<A: Asset, const N: usize> VisitAssetDependencies for [Handle<A>; N] {
fn visit_dependencies(&self, visit: &mut impl FnMut(UntypedAssetId)) {
for dependency in self {
visit(dependency.id().untyped());
}
}
}

impl<const N: usize> VisitAssetDependencies for [UntypedHandle; N] {
fn visit_dependencies(&self, visit: &mut impl FnMut(UntypedAssetId)) {
for dependency in self {
visit(dependency.id());
}
}
}

impl<A: Asset> VisitAssetDependencies for Vec<Handle<A>> {
fn visit_dependencies(&self, visit: &mut impl FnMut(UntypedAssetId)) {
for dependency in self {
Expand Down Expand Up @@ -677,6 +693,7 @@ mod tests {
loader::{AssetLoader, LoadContext},
Asset, AssetApp, AssetEvent, AssetId, AssetLoadError, AssetLoadFailedEvent, AssetPath,
AssetPlugin, AssetServer, Assets, InvalidGenerationError, LoadState, UnapprovedPathMode,
UntypedHandle,
};
use alloc::{
boxed::Box,
Expand Down Expand Up @@ -1892,6 +1909,10 @@ mod tests {
handle: Handle<TestAsset>,
#[dependency]
embedded: TestAsset,
#[dependency]
array_handles: [Handle<TestAsset>; 5],
#[dependency]
untyped_array_handles: [UntypedHandle; 5],
}

#[expect(
Expand Down
Loading