feat: add transformKeysToSnake#39
Merged
vigan-abd merged 9 commits intobitfinexcom:mainfrom Mar 28, 2025
Merged
Conversation
avsek477
requested changes
Mar 7, 2025
btrdnch
reviewed
Mar 7, 2025
avsek477
previously approved these changes
Mar 10, 2025
tarcisiozf
reviewed
Mar 27, 2025
| * @param {Object} obj | ||
| * @returns {Object} | ||
| */ | ||
| const transformKeysToSnakeCase = (obj) => { |
Contributor
There was a problem hiding this comment.
should we have a deep/recursive flag to inform that nested objects should also be applied?
Contributor
Author
There was a problem hiding this comment.
What do you propose, the following?
const transformKeysToSnakeCase = (obj, { recursive } = {}) => {
if (Array.isArray(obj)) {
return obj.map(item => transformKeysToSnakeCase(item))
}
if (!isPlainObject(obj)) {
return obj
}
return Object.fromEntries(
Object.entries(obj).map(([k, v]) => [
snakeCase(k),
recursive ? transformKeysToSnakeCase(v) : v
])
)
}
Contributor
There was a problem hiding this comment.
yeah, I give the consumer more control
tarcisiozf
reviewed
Mar 27, 2025
tarcisiozf
approved these changes
Mar 27, 2025
vigan-abd
approved these changes
Mar 27, 2025
vigan-abd
requested changes
Mar 27, 2025
Contributor
vigan-abd
left a comment
There was a problem hiding this comment.
need to update package-lock.json as well
vigan-abd
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
New features:
PR status: