-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add transformKeysToSnake #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vigan-abd
merged 9 commits into
bitfinexcom:main
from
jsertx:feat/add-transform-keys-to-snake
Mar 28, 2025
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
80bbf22
feat: add transformKeystoSnake + isPlainObject fix
jsertx 1be62c0
chore: resolve conflicts
jsertx 0167588
refactor: fix typo
jsertx 0cd794c
fix: make it work with array of objects
jsertx e1dd42f
refactor: remove useless check
jsertx 35de227
test: remove .only
jsertx 88646a6
Merge remote-tracking branch 'org/main' into feat/add-transform-keys-…
jsertx 0336090
feat: add recursive option
jsertx f1781af
fix: propagate options in recursions
jsertx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| 'use strict' | ||
|
|
||
| const isPlainObject = require('./isPlainObject') | ||
| const snakeCase = require('./snakeCase') | ||
|
|
||
| /** | ||
| * Transform object keys to snake case | ||
| * e.g. { fooBar: 1 } => { foo_bar: 1 } | ||
| * @param {Object} obj | ||
| * @returns {Object} | ||
| */ | ||
| const transformKeysToSnakeCase = (obj) => { | ||
| if (Array.isArray(obj)) { | ||
| return obj.map(item => transformKeysToSnakeCase(item)) | ||
| } | ||
|
|
||
| if (!isPlainObject(obj)) { | ||
| return obj | ||
| } | ||
|
|
||
| return Object.fromEntries( | ||
| Object.entries(obj).map(([k, v]) => [ | ||
| snakeCase(k), | ||
| transformKeysToSnakeCase(v) | ||
| ]) | ||
| ) | ||
| } | ||
|
|
||
| module.exports = transformKeysToSnakeCase | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| 'use strict' | ||
|
|
||
| /* eslint-env mocha */ | ||
|
|
||
| const assert = require('assert') | ||
| const { transformKeysToSnake } = require('../index') | ||
| const { itEach } = require('mocha-it-each') | ||
|
|
||
| describe('transformKeysToSnake', () => { | ||
| itEach('should return input when it is not an object', [new Date(), null, false], (input) => { | ||
| assert.equal(transformKeysToSnake(input), input) | ||
| }) | ||
|
|
||
| it('should return input with snake case props recursively', () => { | ||
| const input = { | ||
| camelProp: 'true', | ||
| nestedProp: { | ||
| first_name: 'john', | ||
| lastName: 'doe', | ||
| tags: ['keepCamel'] | ||
| }, | ||
| someObjs: [ | ||
| { someProp: 'value' }, | ||
| { foo_bar: 'value', foo: 'value' } | ||
| ] | ||
| } | ||
| const output = { | ||
| camel_prop: 'true', | ||
| nested_prop: { | ||
| first_name: 'john', | ||
| last_name: 'doe', | ||
| tags: ['keepCamel'] | ||
| }, | ||
| some_objs: [ | ||
| { some_prop: 'value' }, | ||
| { foo_bar: 'value', foo: 'value' } | ||
| ] | ||
| } | ||
| assert.deepEqual(transformKeysToSnake(input), output) | ||
| }) | ||
|
|
||
| it('should work with', () => { | ||
| const input = { | ||
| mixedArray: [123, { someKey: 'value' }, [{ nestedArrayItem: 'test' }]] | ||
| } | ||
| const output = { | ||
| mixed_array: [123, { some_key: 'value' }, [{ nested_array_item: 'test' }]] | ||
| } | ||
| assert.deepEqual(transformKeysToSnake(input), output) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have a
deep/recursiveflag to inform that nested objects should also be applied?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you propose, the following?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I give the consumer more control