-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add cluster encryption config support to aws_eks module #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chris Gianelloni <[email protected]>
📝 WalkthroughWalkthroughA variable renaming refactoring is performed across two Terraform configuration files. The variable Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
aws_eks/eks.tf (1)
5-12: Consider documenting the breaking change.Renaming a public module input parameter is a breaking change. Consumers of this module who currently use
cluster_encryption_configwill experience failures. Consider adding migration guidance, a CHANGELOG entry, or version bump documentation to help users transition to the new parameter name.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
aws_eks/eks.tf(1 hunks)aws_eks/variables.tf(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cubic · AI code reviewer
🔇 Additional comments (3)
aws_eks/eks.tf (1)
11-11: Module input mapping correctly updated to match the renamed variable.The module input parameter has been updated from
cluster_encryption_configtoencryption_configto align with the renamed variable. This change is consistent with the variable rename in variables.tf.aws_eks/variables.tf (2)
30-39: All references to the old variable name have been successfully updated.The search found no remaining occurrences of
cluster_encryption_configin any Terraform files (.tf) across the repository. The breaking change to rename the variable toencryption_confighas been properly implemented with no incomplete migrations.
30-39: Confirmed: "encryption_config" is the correct parameter name for terraform-aws-modules/eks/aws version 21.0.The web search confirms that the module renamed
cluster_encryption_configtoencryption_configin v21.0.0. The variable structure in your code matches the expected schema (list of objects withresourcesandprovider.key_arn). No action needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
This PR corrects the parameter name for cluster encryption configuration in the aws_eks module, changing from cluster_encryption_config to encryption_config to match the upstream terraform-aws-modules/eks/aws module.
Summary by cubic
Updated the aws_eks module to use encryption_config (instead of cluster_encryption_config) for EKS cluster secret encryption. Aligns with terraform-aws-modules/eks/aws and ensures KMS envelope encryption is configured correctly.
Written for commit fd17259. Summary will update automatically on new commits.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.