Add missing parameter to simple tiled server docstring, fix type hint, allow for both lists and strings, add unit test for readable storage#1321
Open
jwlodek wants to merge 4 commits intobluesky:mainfrom
Conversation
…, allow for both lists and strings, add unit test for readable storage
genematx
reviewed
Mar 27, 2026
| port: int = 0, | ||
| readable_storage: Optional[Union[str, pathlib.Path]] = None, | ||
| readable_storage: Optional[ | ||
| Union[str, pathlib.Path, list[str], list[pathlib.Path]] |
Contributor
There was a problem hiding this comment.
Probably Union[str, pathlib.Path, list[Union[str,pathlib.Path]]] is more accurate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically, when we use
SimpleTiledServerit is in a dev environment where the easiest thing to do is just pointreadable_storageat/tmp(ortmp_pathin unit tests). Requiring a list and having the user enter[/tmp]I think is unnecessary.Also,
readable_storagewas missing from the docstring, and the existing type hint was actually incorrect, since it did not specify that a list was required.Checklist