Adapt sidebar component to support version select #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Preliminary work:** - Display slot 'before' if provides, with `<%= slotted :before %>` - Favor tag h2 for this slot, to have only one h1 per page **Version selector** Be generic, provide a list of selectable version in `data.sidebar_versions` When sidebar_versions are provided, display a (raw) select HTML. TODO: - improve CSS for this select (dedicated component) - improve behavior: add link between v3.1 & v3.2 support smart SEO logic when page is missing
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Polo2
commented
Sep 29, 2025
| <%= resource.data.sidebar_title %> | ||
| <span class="version"><%= resource.data.sidebar_version %></span> | ||
| </h1> | ||
| <%# TODO: move in dedicated component %> |
Member
Author
There was a problem hiding this comment.
This can be done in dedicated commit, and then fix the missing slot in this PR only
Member
Author
|
This PR can not be found anymore, content moved to #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Require #405 to be merged first
Preliminary work: => moved in dedicated PR #405
<%= slotted :before %>Version selector
Be generic, provide a list of selectable version in
data.sidebar_versionsWhen sidebar_versions are provided, display a (raw) select HTML.TODO: