Fix sidebar component to render slot 'before' #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Polo2
force-pushed
the
sidebar--display-and-adapt-missing-slot-before
branch
from
cb889fa to
d75bc05
Compare
Polo2
changed the title
fbraure
reviewed
Sep 30, 2025
| <% if resource.data.sidebar_title.present? %> | ||
| <% sidebar.slot :before do %> | ||
| <h1> | ||
| <h2> |
Contributor
There was a problem hiding this comment.
Do we have another h1 in this page ?
It can be a SEO leak to not have a h1
Member
Author
There was a problem hiding this comment.
Yes, that's because there is already a h1 on this page that I modified to h2
Member
Author
There was a problem hiding this comment.
for example here https://deploy-preview-405--bump-content-hub.netlify.app/guides/openapi/specification/v3.1/introduction/what-is-openapi/
h1 is 'What is OpenAPI?'
Member
Author
There was a problem hiding this comment.
And before this PR, the 'h1' title with content resource.data.sidebar_title was never rendered (because slot was missing)
Polo2
commented
Sep 30, 2025
With this preliminary PR, we display the missing title h2 in sidebar component, when provided via slot `before`. - Display slot 'before' if provides, with `<%= slotted :before %>` - Favor tag h2 for this slot, to have only one h1 per page This PR will be necessary to display a OpenAPI version select button, and prepare the release of version v3.2
Polo2
force-pushed
the
sidebar--display-and-adapt-missing-slot-before
branch
from
d75bc05 to
0529c08
Compare
Polo2
added a commit
that referenced
this pull request
Oct 3, 2025
Since #405, slot 'before' is visible, with h2 tag. But margin-top has to be removed to maintain same vertical spacing.
Polo2
added a commit
that referenced
this pull request
Oct 3, 2025
Since #405, slot 'before' is visible, with h2 tag. But margin-top has to be removed to maintain same vertical spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this preliminary PR,
we display the missing title in sidebar component, when provided via slot
before.<%= slotted :before %>This PR will be necessary to display a OpenAPI version select button, and prepare the release of version v3.2 (cf #404 )
compliant with Figma
before:
now => visible here https://deploy-preview-405--bump-content-hub.netlify.app/guides/openapi/specification/v3.1/introduction/what-is-openapi/
related to https://github.com/bump-sh/bump/issues/7697