-
Notifications
You must be signed in to change notification settings - Fork 14
Reintroduce OpenAPI v3.2 Specification - with version selector #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1ea89f1 to
02f3635
Compare
|
Sorry for all those commit names, I am used to doing Squash Merges so didn't think I'd be littering your inbox. I'll squash on my end next time. |
Don't worry Phil it was easy to handle this big squash, and have a fresh base to handle the version select |
02f3635 to
8a1573b
Compare
06ec6c5 to
8adfe5c
Compare
|
Cc @jayk-u , as discussed, I started a basic dropdown behavior, to allow navigation between versions only when pages exists. for example: this page exits on v3.2 only, the selector can not redirect to v3.1 this page exits in both v3.1 and v3.2, the selector handles redirection Can you confirm this is how you wanted it? |
|
@Polo2 Absolutely, that’s exactly what I needed, thank you! |
I don't see any valuable reason to update this "src/_guides/openapi/specification/v3.1" folder to improve the dropdown component, so yes, you're free to add canonical 🛶 🇳🇮 urls to all these files. As discussed, please favor a single commit for all these changes, since we still have to improve the code (what is it about my CSS?) |
|
As requested, I added the
Is this how you needed it @Polo2 ? |
Yes, exactly! I've got two small feedbacks with these canonical_urls:
Beside that, LGTM. |
Revert #403, back to #359 with a single commit Old commits list: - "oas: default example was wrong"" - "copy oas 3.1 with oas 3.2 changes"" - "more about tag kind and parent"" - "security scheme deprecation"" - "response description is optional"" - "response no content means no content"" - "security schemes can be references now too"" - "removed trailing slash"" - "use newer rfc relative ref pointer links"" - "more about tags, oauth2, and server names"" - "guide: pagination"" - "quick punt at streaming"" - "fix broken link"" - "improved json streaming guide"" - "new and improved json streaming guide"" - "couple more tweaks"" - "link to new spec""
db1efc6 to
924512f
Compare
paulRbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks for this nice improvement
924512f to
152d538
Compare
a8d7ee1 to
930c6fc
Compare
02f7c36 to
8cedac8
Compare
- add canonical urls when needed to 3.1 pages - update dates on 3.2 pages when relevant
8cedac8 to
c465c65
Compare
This is a tricky one, may I ask some support please :) Behavior of this component: when current version is v3.1, detect if there is a similar page (ie wiht similar url) for other version v3.2 if yes, this is a link to this page if no, no link and strikethrough for example: this page exits on v3.2 only, the selector can not redirect to v3.1 guides/openapi/specification/v3.2/advanced/json-streaming/ this page exits in both v3.1 and v3.2, the selector handles redirection guides/openapi/specification/v3.2/understanding-structure/basic-structure/ Improve version selector dropdown UX - Add animated caret rotation (points down when closed, up when open) - Add checkmark icon for currently selected version - Improve dropdown positioning and styling with design system variables - Update toggle controller to manage dropdown state on container element - Refactor dropdown styles to use consistent spacing and design tokens
c465c65 to
2599af6
Compare



Reverts #403, re-revert #329
Squashed in a single commit (we don't want 20 revert revert commits)
Old commits list:
WIP: add a version selector to switch between version 3.1 and 3.2.
Currently, only current version is displayed (thanks to #405 )