-
Notifications
You must be signed in to change notification settings - Fork 226
docs(web-modeler): adjust collaboration for keycloak special handling… #7439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 🤖 🤔 Hello, @afgambin! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.8/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
...onents/modeler/web-modeler/collaboration/img/web-modeler-collaborator-invite-choose-role.png
Show resolved
Hide resolved
a8e1beb to
4daa971
Compare
4daa971 to
fbcb6fc
Compare
|
@afgambin can you please support @JacobiCamunda with a review here? 🙏 |
pablocabrera85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. 🚀 Left one small suggestion. If a customer upgrades to 8.9 and had pending invitations, do they need to do anything or are they affected by this change? If yes, would it make sense to document it?
docs/components/modeler/web-modeler/collaboration/collaboration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Pablo Agustin Cabrera <[email protected]>
The concept of pending invitations is reintroduced with 8.9 for Self-Managed (we had this before and removed it). Right now you only add people directly and for Keycloak the users are created for them even if they did not log in before. Therefore, most likely there are no pending invitations (I don't know when we removed it) and there is no problem. Even if they had pending invitations, this is no problem because they will be just accepted when they log in for the first time. There should be no problem. But good that you thought about this 🙂 |
afgambin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, tweaked a bit some text. lgtm now!
… removal
Description
Adjust documentation accordingly for removing the special handling of Keycloak.
Closes https://github.com/camunda/web-modeler/issues/19222
When should this change go live?
This is a bug fix, security concern, or something that needs urgent release support. (addbugorsupportlabel)This is already available but undocumented and should be released within a week. (addavailable & undocumentedlabel)This is on a specific schedule and the assignee will coordinate a release with the Documentation team. (create draft PR and/or addholdlabel)There is no urgency with this change (addlow priolabel)PR Checklist
{type}(scope): {description}commit message(s)/docsdirectory (version 8.9).My changes are for an already released minor and are in a/versioned_docsdirectory.@camunda/tech-writersunless working with an embedded writer.