Skip to content

[macos] macOS install script cleanup#4988

Open
sharder996 wants to merge 5 commits into
mainfrom
kaizen/macos-cleanup
Open

[macos] macOS install script cleanup#4988
sharder996 wants to merge 5 commits into
mainfrom
kaizen/macos-cleanup

Conversation

@sharder996

@sharder996 sharder996 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Cleaning up some old macOS packaging scripts.

@sharder996 sharder996 requested review from a team, Copilot and jimporter and removed request for a team June 24, 2026 22:47
@sharder996 sharder996 requested review from xmkg and removed request for jimporter June 24, 2026 22:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes macOS packaging scripts and documentation by removing legacy packaging steps and updating launchctl usage to newer subcommands.

Changes:

  • Replaced deprecated launchctl load/unload -w usage with bootstrap/bootout across macOS install/uninstall scripts and docs.
  • Updated the preinstall macOS version check to use the full product version string (instead of only the major version).
  • Removed the Homebrew OpenSSL rpath fixup script and its invocation from the macOS packaging flow.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packaging/macos/uninstall.sh Uses launchctl bootout instead of deprecated unload -w during uninstall.
packaging/macos/preinstall-multipassd.sh.in Updates macOS version detection/check logic.
packaging/macos/postinstall-multipassd.sh.in Uses bootout/bootstrap instead of unload/load -w when installing the LaunchDaemon.
packaging/macos/postinstall-multipass.sh.in Removes legacy cleanup and uses explicit exit 0.
packaging/macos/postinstall-multipass-gui.sh.in Fixes Applications path and uses explicit exit 0.
packaging/macos/install-ssl-libs.sh Deleted (previously handled OpenSSL dylib relocation/rpath rewriting).
packaging/cpack.cmake Removes invocation of the deleted install-ssl-libs.sh.
docs/how-to-guides/troubleshoot/troubleshoot-launch-start-issues.md Updates troubleshooting commands to modern launchctl equivalents.
docs/how-to-guides/customise-multipass/configure-where-multipass-stores-external-data.md Updates stop/start instructions to bootout/bootstrap.
docs/how-to-guides/customise-multipass/configure-multipass-default-logging-level.md Updates stop/start instructions to bootout/bootstrap.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packaging/macos/preinstall-multipassd.sh.in
Comment thread packaging/macos/postinstall-multipassd.sh.in Outdated
@sharder996 sharder996 force-pushed the kaizen/macos-cleanup branch from fc47b27 to bc8a4a8 Compare June 24, 2026 22:56
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.60%. Comparing base (61c8a09) to head (067b61f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4988   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         274      274           
  Lines       14649    14649           
=======================================
  Hits        12832    12832           
  Misses       1817     1817           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings June 26, 2026 16:12
@sharder996 sharder996 force-pushed the kaizen/macos-cleanup branch from bc8a4a8 to 067b61f Compare June 26, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

packaging/macos/postinstall-multipass.sh.in:8

  • Paths built from the installer destination root ($3) should include a slash (and be quoted) so installs targeting a non-root volume don’t produce paths like /Volumes/MyDiskusr/local/bin. This script already uses $3/… in other macOS installer scripts.
### /usr/local/bin doesn't exist on a clean OSX install, yet it is in the default $PATH!
mkdir -p ${3}usr/local/bin

### Set up symlink to new multipass binary
ln -fsv "${3}@CPACK_PACKAGING_INSTALL_PREFIX@/bin/multipass" "${3}usr/local/bin/multipass"

Comment thread packaging/macos/preinstall-multipassd.sh.in
Comment thread packaging/macos/preinstall-multipassd.sh.in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants