Skip to content

DPE-7649 Replace event.set_results(success=False) with event.fail() in action get-cluster-status #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
astrojuanlu merged 2 commits into from
Oct 27, 2025
Merged

DPE-7649 Replace event.set_results(success=False) with event.fail() in action get-cluster-status #673

astrojuanlu merged 2 commits into from
Oct 27, 2025

Conversation

@astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu commented Oct 27, 2025

Issue

Fix canonical/mysql-operator#649

Backport of canonical/mysql-operator#699

Solution

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Oct 27, 2025
@astrojuanlu astrojuanlu added the bug Something isn't working as expected label Oct 27, 2025
sinclert-canonical
sinclert-canonical requested changes Oct 27, 2025
View reviewed changes
@astrojuanlu
Copy link
Contributor Author

astrojuanlu commented Oct 27, 2025 •
edited
Loading

I didn't see the local failure of the unit tests because I did have a k8s cluster. Looking into this.

(Understood, see above)

@astrojuanlu
test: remove unwanted tests
02d8fb7 
Charm libs must be tested upstream, as is already the case.
@astrojuanlu astrojuanlu merged commit 97d4fda into main Oct 27, 2025
118 of 123 checks passed
@astrojuanlu astrojuanlu deleted the bugfix/get-cluster-status-fail branch October 27, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulomach paulomach paulomach approved these changes

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

@sinclert-canonical sinclert-canonical sinclert-canonical approved these changes

Assignees

No one assigned

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

On action get_cluster_status failure, results are set as if success

5 participants

@astrojuanlu @paulomach @carlcsaposs-canonical @sinclert-canonical